From: Denis Kenzior <denkenz@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
James Prestwood <prestwoj@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: Support LIVE_ADDRESS_CHANGE feature
Date: Tue, 8 Oct 2019 11:23:14 -0500 [thread overview]
Message-ID: <1bb5450b-bc4e-8c83-f99e-fc7e739b08f0@gmail.com> (raw)
In-Reply-To: <f02b81f6dac29da911f8793b952a9efb6a1fdb62.camel@sipsolutions.net>
Hi Johannes,
>> Indeed. But that is not what you were suggesting earlier with just
>> checking local->scanning. So if scan_req contains a wdev, then yes it
>> should be possible to compare the scan_req->wdev to the interface being
>> changed.
>
> Well, yes, but only because I was incrementally going from James's
> patch, which was checking that only.
Well, something to improve. Sometimes it is pretty hard to figure out
what you mean.
>
> Similar with the other local-> things being checked here, btw, though in
> some cases it might be harder to actually determine which wdev is doing
> something and which isn't.
Right
>
>>> No, this typically cannot be fixed, and it doesn't really make sense.
>>> The NIC cannot possibly do two scans at a time since it has only a
>>> single radio resource :-)
>>
>> So why is the scan request not per phy then? And should mac address
>> even affect the ongoing scan? Can we simply change it with the scan
>> ongoing?
>
> There are things that affect the scan from the interface, e.g.
> capability overrides, (extended) capabilities, the MAC address is used
> unless randomization is requested, etc.
>
But they shouldn't change due a mac address change? I wonder if we can
further relax the requirements to allow mac change if
NL80211_SCAN_FLAG_RANDOM_ADDR was used?
Regards,
-Denis
next prev parent reply other threads:[~2019-10-08 16:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 19:59 [PATCH 1/2] nl80211: Add LIVE_ADDR_CHANGE feature James Prestwood
2019-09-13 19:59 ` [PATCH 2/2] mac80211: Support LIVE_ADDRESS_CHANGE feature James Prestwood
2019-10-04 11:56 ` Johannes Berg
2019-10-04 16:25 ` James Prestwood
2019-10-04 16:42 ` James Prestwood
2019-10-07 21:16 ` Johannes Berg
2019-10-08 15:37 ` Denis Kenzior
2019-10-08 15:52 ` Johannes Berg
2019-10-08 15:53 ` Denis Kenzior
2019-10-08 16:24 ` Johannes Berg
2019-10-08 16:23 ` Denis Kenzior [this message]
2019-10-08 17:08 ` Johannes Berg
2019-10-08 18:50 ` Denis Kenzior
2019-10-08 20:16 ` Johannes Berg
2019-10-08 20:55 ` Denis Kenzior
2019-10-10 15:18 ` Johannes Berg
2019-10-07 21:11 ` Johannes Berg
2019-10-08 15:28 ` Denis Kenzior
2019-10-08 15:49 ` Johannes Berg
2019-09-13 20:48 ` [PATCH 1/2] nl80211: Add LIVE_ADDR_CHANGE feature Johannes Berg
2019-09-13 20:56 ` James Prestwood
2019-09-13 21:01 ` Johannes Berg
2019-09-13 21:14 ` James Prestwood
2019-09-17 20:09 ` James Prestwood
2019-10-01 9:14 ` Johannes Berg
2019-10-08 22:13 ` James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bb5450b-bc4e-8c83-f99e-fc7e739b08f0@gmail.com \
--to=denkenz@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).