From: Johannes Berg <johannes@sipsolutions.net>
To: Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v7 3/5] wifi: mac80211: handle set csa/after_csa beacon on per link basis
Date: Tue, 30 Jan 2024 11:17:33 +0100 [thread overview]
Message-ID: <1e73c061653abf8e5f1671ae026e0905b2fb4ded.camel@sipsolutions.net> (raw)
In-Reply-To: <20240130043225.942202-4-quic_adisi@quicinc.com>
On Tue, 2024-01-30 at 10:02 +0530, Aditya Kumar Singh wrote:
> In order to support CSA with MLO, there is a need to handle the functions
> ieee80211_set_csa_beacon() and ieee80211_set_after_csa_beacon() on per
> link basis.
nit: "on a per link"
> Add changes for the same.
Is that some cultural thing?
I always find this phrasing with "for the same" very odd, and would
rather say something useful such as "Implement this by passing the
correct link data"... but I see this a lot, hence the question.
> @@ -3658,7 +3659,7 @@ static int __ieee80211_csa_finalize(struct ieee80211_link_data *link_data)
>
> sdata->vif.bss_conf.csa_active = false;
>
> - err = ieee80211_set_after_csa_beacon(sdata, &changed);
> + err = ieee80211_set_after_csa_beacon(&sdata->deflink, &changed);
weren't you just saying deflink shouldn't be used?
> @@ -3928,7 +3930,7 @@ __ieee80211_channel_switch(struct wiphy *wiphy, struct net_device *dev,
> if (sdata->vif.bss_conf.color_change_active)
> ieee80211_color_change_abort(sdata);
>
> - err = ieee80211_set_csa_beacon(sdata, params, &changed);
> + err = ieee80211_set_csa_beacon(&sdata->deflink, params, &changed);
dito
johannes
next prev parent reply other threads:[~2024-01-30 10:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 4:32 [PATCH v7 0/5] wifi: cfg80211/mac80211: add link_id handling in AP channel switch during Multi-Link Operation Aditya Kumar Singh
2024-01-30 4:32 ` [PATCH v7 1/5] wifi: cfg80211: send link id in channel_switch ops Aditya Kumar Singh
2024-01-30 10:13 ` Johannes Berg
2024-01-30 10:35 ` Aditya Kumar Singh
2024-01-30 10:36 ` Johannes Berg
2024-01-30 4:32 ` [PATCH v7 2/5] wifi: mac80211: update beacon counters per link basis Aditya Kumar Singh
2024-01-30 4:32 ` [PATCH v7 3/5] wifi: mac80211: handle set csa/after_csa beacon on " Aditya Kumar Singh
2024-01-30 10:17 ` Johannes Berg [this message]
2024-01-30 10:43 ` Aditya Kumar Singh
2024-01-30 13:50 ` Aditya Kumar Singh
2024-01-30 13:51 ` Johannes Berg
2024-01-30 4:32 ` [PATCH v7 4/5] wifi: mac80211: start and finalize channel switch on " Aditya Kumar Singh
2024-01-30 4:32 ` [PATCH v7 5/5] wifi: mac80211: add support to call csa_finish on a link Aditya Kumar Singh
2024-01-30 10:21 ` Johannes Berg
2024-01-30 10:53 ` Aditya Kumar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e73c061653abf8e5f1671ae026e0905b2fb4ded.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_adisi@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).