From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: j@w1.fi, greearb@candelatech.com
Subject: Re: [RFC v2 3/7] ieee80211: add new VHT capability fields/parsing
Date: Wed, 15 Feb 2017 11:34:08 +0100 [thread overview]
Message-ID: <1f3197b6-2860-632c-bbbb-3afac16f6edc@broadcom.com> (raw)
In-Reply-To: <1487152112.4026.19.camel@sipsolutions.net>
On 15-2-2017 10:48, Johannes Berg wrote:
> On Wed, 2017-02-15 at 10:36 +0100, Arend Van Spriel wrote:
>>
>>> I'm not really sure what to do - we don't really want to print a
>>> message on something that might have been received from the peer, I
>>> think? Though I suppose we should return 0 for the invalid
>>> combinations, indicating that they're not supported.
>>
>> Ah. This is all non-functional code yet, right? At least having a
>> static non-inline function in ieee80211.h will give build issues I
>> would think.
>
> No, I marked it __maybe_unused so it'll be fine. I didn't want to have
> it inlined if you use it multiple times in a single source file, but I
> didn't want to move it to somewhere else either ...
Ah. Now I understand the trickery ;-) Was there really no "somewhere
else" to move it, because honestly it is confusing and a bit wasteful if
used multiple times in cfg80211 and/or drivers.
Gr. AvS
>> Anyway, I would indeed return 0 and have caller deal with that.
>
> Yeah, I'll do that.
>
> johannes
>
next prev parent reply other threads:[~2017-02-15 10:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 13:22 VHT extended NSS BW support framework Johannes Berg
2017-02-14 13:22 ` [RFC v2 1/7] ieee80211: rename CCFS1/CCFS2 to CCFS0/CCFS1 Johannes Berg
2017-02-14 13:22 ` [RFC v2 2/7] ieee80211: define HT operation CCFS2 field Johannes Berg
2017-02-14 13:22 ` [RFC v2 3/7] ieee80211: add new VHT capability fields/parsing Johannes Berg
2017-02-15 9:08 ` Arend Van Spriel
2017-02-15 9:16 ` Johannes Berg
2017-02-15 9:36 ` Arend Van Spriel
2017-02-15 9:48 ` Johannes Berg
2017-02-15 10:34 ` Arend Van Spriel [this message]
2017-02-15 10:34 ` Arend Van Spriel
2017-02-15 10:41 ` Johannes Berg
2017-02-15 10:54 ` Arend Van Spriel
2017-02-14 13:22 ` [RFC v2 4/7] mac80211: remove local pointer from rate_ctrl_ref Johannes Berg
2017-02-14 13:22 ` [RFC v2 5/7] mac80211: introduce capability flags for VHT EXT NSS support Johannes Berg
2017-02-14 13:22 ` [RFC v2 6/7] mac80211: add ability to parse CCFS2 Johannes Berg
2017-02-14 13:22 ` [RFC v2 7/7] mac80211: copy VHT EXT NSS BW Support/Capable data to station Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f3197b6-2860-632c-bbbb-3afac16f6edc@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=greearb@candelatech.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).