linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: "Philip A. Prindeville" <philipp_subx@redfish-solutions.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: Using compat-wireless w/ 2.6.27.26
Date: Thu, 23 Jul 2009 07:24:28 -0400	[thread overview]
Message-ID: <20090723112428.GC13742@hash.localnet> (raw)
In-Reply-To: <4A6620B9.4@redfish-solutions.com>

On Tue, Jul 21, 2009 at 01:10:33PM -0700, Philip A. Prindeville wrote:
> A little progress:  I build 2009-07-10 with 2.6.27.26, and I can get the
> Vista box to associate, but not an iPhone running 3.0...

Here's a start, but I still need to find and fix another issue.

Ath5k seems to have had an implicit assumption that config() would
be called before beacon setup and the opmode would get set in HW then.
Not sure if the order changed when beacon stuff was moved to bss_conf,
but it's fragile anyway so I think we should configure the mode up
front so that the timers actually work.  Also we need to process all
of the TX queue's status descriptors.

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index c00f83f..168649d 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -1117,6 +1117,8 @@ ath5k_mode_setup(struct ath5k_softc *sc)
 	struct ath5k_hw *ah = sc->ah;
 	u32 rfilt;
 
+	ah->ah_op_mode = sc->opmode;
+
 	/* configure rx filter */
 	rfilt = sc->filter_flags;
 	ath5k_hw_set_rx_filter(ah, rfilt);
@@ -1999,8 +2001,13 @@ static void
 ath5k_tasklet_tx(unsigned long data)
 {
 	struct ath5k_softc *sc = (void *)data;
+	int i;
 
-	ath5k_tx_processq(sc, sc->txq);
+	for (i=0; i < AR5K_NUM_TX_QUEUES; i++) {
+		if (!sc->txqs[i].setup)
+			continue;
+		ath5k_tx_processq(sc, sc->txq);
+	}
 }
 
 
@@ -2768,6 +2775,7 @@ static int ath5k_add_interface(struct ieee80211_hw *hw,
 	}
 
 	ath5k_hw_set_lladdr(sc->ah, conf->mac_addr);
+	ath5k_mode_setup(sc);
 
 	ret = 0;
 end:

-- 
Bob Copeland %% www.bobcopeland.com


  parent reply	other threads:[~2009-07-23 11:25 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-18  1:27 Using compat-wireless w/ 2.6.27.26 Philip A. Prindeville
2009-07-19  8:58 ` Philip A. Prindeville
2009-07-19 13:38 ` Bob Copeland
2009-07-19 17:55   ` Philip A. Prindeville
2009-07-19 20:31     ` Bob Copeland
2009-07-20  3:05       ` Philip A. Prindeville
2009-07-20 11:52         ` Bob Copeland
2009-07-20 19:16           ` Philip A. Prindeville
2009-07-20 19:47             ` Luis R. Rodriguez
2009-07-20 23:52               ` Philip A. Prindeville
2009-07-21 20:10                 ` Philip A. Prindeville
2009-07-21 23:24                   ` Luis R. Rodriguez
2009-07-22  3:28                   ` Bob Copeland
2009-07-23 11:24                   ` Bob Copeland [this message]
2009-07-23 11:59                     ` Bob Copeland
2009-07-23 20:29                       ` Philip A. Prindeville
2009-07-23 20:33                         ` Bob Copeland
2009-07-23 21:53                         ` Philip A. Prindeville
2009-07-23 22:21                           ` Bob Copeland
2009-07-23 22:45                             ` Philip A. Prindeville
2009-07-24 13:58                               ` Bob Copeland
2009-07-30  4:36                                 ` Philip A. Prindeville
2009-07-21 23:26               ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090723112428.GC13742@hash.localnet \
    --to=me@bobcopeland.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    --cc=philipp_subx@redfish-solutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).