From: Michael Buesch <mb@bu3sch.de>
To: linville@tuxdriver.com
Cc: gregor kowski <gregor.kowski@gmail.com>,
bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] remove wrong probe_resp_plcp write
Date: Fri, 31 Jul 2009 22:38:14 +0200 [thread overview]
Message-ID: <200907312238.15705.mb@bu3sch.de> (raw)
In-Reply-To: <83a869cd0907311335h3065547aqc736573a663b6d42@mail.gmail.com>
On Friday 31 July 2009 22:35:49 gregor kowski wrote:
> The tkip hw support uncovered a bug in b43_write_probe_resp_template : it is
> writing at the wrong shm offset, it is in the B43_SHM_SH_TKIPTSCTTAK zone. This
> patch comments these writes.
>
> Signed-off-by: Gregor Kowski <gregor.kowski@gmail.com>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> Index: linux-2.6/drivers/net/wireless/b43/main.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/wireless/b43/main.c 2009-07-31
> 20:32:21.000000000 +0000
> +++ linux-2.6/drivers/net/wireless/b43/main.c 2009-07-31
> 20:32:28.000000000 +0000
> @@ -1505,10 +1505,13 @@
> /* Looks like PLCP headers plus packet timings are stored for
> * all possible basic rates
> */
> + /* FIXME this is the wrong offset : it goes in tkip rx phase1 shm */
> +#if 0
> b43_write_probe_resp_plcp(dev, 0x31A, size, &b43_b_ratetable[0]);
> b43_write_probe_resp_plcp(dev, 0x32C, size, &b43_b_ratetable[1]);
> b43_write_probe_resp_plcp(dev, 0x33E, size, &b43_b_ratetable[2]);
> b43_write_probe_resp_plcp(dev, 0x350, size, &b43_b_ratetable[3]);
> +#endif
>
> size = min((size_t) size, 0x200 - sizeof(struct b43_plcp_hdr6));
> b43_write_template_common(dev, probe_resp_data,
>
>
--
Greetings, Michael.
next prev parent reply other threads:[~2009-07-31 20:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 20:35 [PATCH] remove wrong probe_resp_plcp write gregor kowski
2009-07-31 20:38 ` Michael Buesch [this message]
2009-08-04 16:05 ` John W. Linville
2009-08-04 20:27 ` Michael Buesch
2009-08-04 20:33 ` Johannes Berg
2009-08-04 21:58 ` gregor kowski
2009-08-04 22:04 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907312238.15705.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=gregor.kowski@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).