linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: Joerg Albert <jal2@gmx.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	ath5k-devel@lists.ath5k.org,
	"Luis R. Rodriguez" <lrodriguez@atheros.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath5k: fix missing output in monitor mode after ifconfig up
Date: Sat, 1 Aug 2009 23:20:20 -0400	[thread overview]
Message-ID: <20090802032019.GA25339@hash.localnet> (raw)
In-Reply-To: <4A74C2B6.3070407@gmx.de>

On Sun, Aug 02, 2009 at 12:33:26AM +0200, Joerg Albert wrote:
> Let ath5k_chan_set() call ath5k_reset() if ath5k_config() was told
> that the channel changed. This fixes the bug that we don't
> get any packets in monitor mode after:

Cool, thanks for the patch.  Just a couple of comments:

> +                              int chan_changed);

Should use bool for that.

> -       ret = ath5k_chan_set(sc, conf->channel);
> +       ret = ath5k_chan_set(sc, conf->channel,
> +                            changed & IEEE80211_CONF_CHANGE_CHANNEL);

Since this is the only place ath5k_chan_set is called, how about changing
ath5k_chan_set to unconditionally do a reset, and put the test outside?

i.e.:

        if (changed & IEEE80211_CONF_CHANGE_CHANNEL)
                ath5k_chan_set(sc, conf->channel);

Thanks!

-- 
Bob Copeland %% www.bobcopeland.com


  reply	other threads:[~2009-08-02  3:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-01 22:33 [PATCH] ath5k: fix missing output in monitor mode after ifconfig up Joerg Albert
2009-08-02  3:20 ` Bob Copeland [this message]
2009-08-02  7:36   ` Joerg Albert
2009-08-02  7:50   ` [PATCH v2] " Joerg Albert
2009-08-04 15:13     ` Bob Copeland
2009-08-04 15:41     ` John W. Linville
2009-08-04 23:46       ` Joerg Albert
2009-08-04 23:52       ` [PATCH v3] " Joerg Albert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090802032019.GA25339@hash.localnet \
    --to=me@bobcopeland.com \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=jal2@gmx.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).