From: "John W. Linville" <linville@tuxdriver.com>
To: Nick Kossifidis <mickflemm@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Jiri Slaby <jirislaby@gmail.com>,
linux-wireless@vger.kernel.org, ath5k-devel@lists.ath5k.org
Subject: Re: [ath5k-devel] [PATCH 4/4] ath5k: Use SWI to trigger calibration
Date: Fri, 7 Aug 2009 10:55:55 -0400 [thread overview]
Message-ID: <20090807145555.GD7545@tuxdriver.com> (raw)
In-Reply-To: <40f31dec0908031054m3b8231fdrf36f363702218116@mail.gmail.com>
On Mon, Aug 03, 2009 at 08:54:47PM +0300, Nick Kossifidis wrote:
> 2009/8/1 Johannes Berg <johannes@sipsolutions.net>:
> > On Sat, 2009-08-01 at 10:24 +0200, Jiri Slaby wrote:
> >> On 08/01/2009 10:21 AM, Johannes Berg wrote:
> >> > Actually, jiffies are unsigned long
> >>
> >> Yeah, this is what I meant. I agree I messed it up when I didn't write
> >> the unsigned explicitly. It might have been confusing, thanks for
> >> pointing out.
> >
> > And, in addition to what you said, the code shouldn't divide jiffies, it
> > should multiply the timeout, add it to the start time, and then use
> > time_is_after_jiffies() or so.
> >
> > johannes
>
> ACK will resend asap ;-)
Last I saw in this thread...
Can we have a clean repost of the whole series (including proper
Signed-off-by and any Acked-by, Tested-by, etc)? Also, in the future
I think it would be good for you to take some of the comments from
Luis to heart -- explain the 'why' not the 'what' in the changelogs,
do one thing per patch, etc.
I'm going to drop the original 1-4 now and wait for a clean repost.
Thanks,
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-08-07 15:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 18:10 [PATCH 4/4] ath5k: Use SWI to trigger calibration Nick Kossifidis
2009-07-31 18:15 ` Luis R. Rodriguez
2009-07-31 18:25 ` [ath5k-devel] " Nick Kossifidis
2009-07-31 18:48 ` Luis R. Rodriguez
2009-07-31 19:09 ` Pavel Roskin
2009-07-31 19:35 ` Nick Kossifidis
2009-07-31 19:43 ` Pavel Roskin
2009-07-31 19:11 ` Bob Copeland
2009-07-31 19:52 ` Nick Kossifidis
2009-08-01 13:22 ` Bob Copeland
2009-08-01 13:31 ` Nick Kossifidis
2009-08-02 16:14 ` Bob Copeland
2009-07-31 18:34 ` Nick Kossifidis
2009-08-01 5:46 ` Nick Kossifidis
2009-08-01 8:19 ` Jiri Slaby
2009-08-01 8:21 ` Johannes Berg
2009-08-01 8:24 ` Jiri Slaby
2009-08-01 8:28 ` Johannes Berg
2009-08-01 8:31 ` [ath5k-devel] " Nick Kossifidis
2009-08-01 8:35 ` Jiri Slaby
2009-08-03 17:54 ` Nick Kossifidis
2009-08-07 14:55 ` John W. Linville [this message]
2009-08-07 19:50 ` Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090807145555.GD7545@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).