From: Randy Dunlap <randy.dunlap@oracle.com>
To: Luciano Coelho <luciano.coelho@nokia.com>
Cc: ext Stephen Rothwell <sfr@canb.auug.org.au>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wl1271: fix compiler warnings on 64 bit archs
Date: Tue, 11 Aug 2009 11:45:18 -0700 [thread overview]
Message-ID: <20090811114518.d45d4006.randy.dunlap@oracle.com> (raw)
In-Reply-To: <4A81BB47.2020607@nokia.com>
On Tue, 11 Aug 2009 21:41:11 +0300 Luciano Coelho wrote:
> ext Stephen Rothwell wrote:
> > Hi Luciano,
> >
> > On Tue, 11 Aug 2009 11:58:27 +0300 Luciano Coelho <luciano.coelho@nokia.com> wrote:
> >
> >> +++ b/drivers/net/wireless/wl12xx/wl1271_boot.c
> >> @@ -100,8 +100,8 @@ static int wl1271_boot_upload_firmware_chunk(struct wl1271 *wl, void *buf,
> >>
> >> wl1271_debug(DEBUG_BOOT, "starting firmware upload");
> >>
> >> - wl1271_debug(DEBUG_BOOT, "fw_data_len %d chunk_size %d", fw_data_len,
> >> - CHUNK_SIZE);
> >> + wl1271_debug(DEBUG_BOOT, "fw_data_len %d chunk_size %d",
> >> + (u32) fw_data_len, CHUNK_SIZE);
> >>
> >
> > fw_data_len is a size_t and so should be printed with %zd.
> >
> >
> >> @@ -148,7 +148,7 @@ static int wl1271_boot_upload_firmware_chunk(struct wl1271 *wl, void *buf,
> >> addr = dest + chunk_num * CHUNK_SIZE;
> >> p = buf + chunk_num * CHUNK_SIZE;
> >> wl1271_debug(DEBUG_BOOT, "uploading fw last chunk (%d B) 0x%p to 0x%x",
> >> - fw_data_len % CHUNK_SIZE, p, addr);
> >> + (u32) fw_data_len % CHUNK_SIZE, p, addr);
> >>
> >
> > ditto.
> >
>
> Thanks! I didn't know about the z length modifier for printf (everyday
> learning something new!), I should have checked the manpage. I'll fix
> this and send v2 of my patch.
man page is fine, but you can also check (in the kernel source tree)
Documentation/printk-formats.txt
---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
next prev parent reply other threads:[~2009-08-11 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 8:58 [PATCH] wl1271: fix compiler warnings on 64 bit archs Luciano Coelho
2009-08-11 10:07 ` Stephen Rothwell
2009-08-11 18:41 ` Luciano Coelho
2009-08-11 18:45 ` Randy Dunlap [this message]
2009-08-11 19:15 ` John W. Linville
2009-08-11 19:43 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090811114518.d45d4006.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luciano.coelho@nokia.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).