From: "John W. Linville" <linville@tuxdriver.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Jouni Malinen <jmalinen@atheros.com>,
linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org,
Andrew Morton <akpm@linux-foundation.org>,
m.sujith@gmail.com, mcgrof@gmail.com
Subject: Re: [PATCH] ath9k: Fix read buffer overflow
Date: Tue, 11 Aug 2009 14:25:14 -0400 [thread overview]
Message-ID: <20090811182514.GF2634@tuxdriver.com> (raw)
In-Reply-To: <4A811464.4030108@gmail.com>
Comments from the ath9k crowd?
On Tue, Aug 11, 2009 at 08:49:08AM +0200, Roel Kluin wrote:
> Prevent a read of powInfo[-1] in the first iteration.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/net/wireless/ath/ath9k/eeprom.c b/drivers/net/wireless/ath/ath9k/eeprom.c
> index ce0e86c..e67db2c 100644
> --- a/drivers/net/wireless/ath/ath9k/eeprom.c
> +++ b/drivers/net/wireless/ath/ath9k/eeprom.c
> @@ -150,10 +150,10 @@ static void ath9k_hw_get_legacy_target_powers(struct ath_hw *ah,
> IS_CHAN_2GHZ(chan))) {
> matchIndex = i;
> break;
> - } else if ((freq < ath9k_hw_fbin2freq(powInfo[i].bChannel,
> - IS_CHAN_2GHZ(chan))) &&
> - (freq > ath9k_hw_fbin2freq(powInfo[i - 1].bChannel,
> - IS_CHAN_2GHZ(chan)))) {
> + } else if (freq < ath9k_hw_fbin2freq(powInfo[i].bChannel,
> + IS_CHAN_2GHZ(chan)) && i > 0 &&
> + freq > ath9k_hw_fbin2freq(powInfo[i - 1].bChannel,
> + IS_CHAN_2GHZ(chan))) {
> lowIndex = i - 1;
> break;
> }
> @@ -268,10 +268,10 @@ static void ath9k_hw_get_target_powers(struct ath_hw *ah,
> matchIndex = i;
> break;
> } else
> - if ((freq < ath9k_hw_fbin2freq(powInfo[i].bChannel,
> - IS_CHAN_2GHZ(chan))) &&
> - (freq > ath9k_hw_fbin2freq(powInfo[i - 1].bChannel,
> - IS_CHAN_2GHZ(chan)))) {
> + if (freq < ath9k_hw_fbin2freq(powInfo[i].bChannel,
> + IS_CHAN_2GHZ(chan)) && i > 0 &&
> + freq > ath9k_hw_fbin2freq(powInfo[i - 1].bChannel,
> + IS_CHAN_2GHZ(chan))) {
> lowIndex = i - 1;
> break;
> }
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-08-11 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 21:50 [PATCH] ath9k: Fix read buffer overflow Roel Kluin
2009-08-10 20:26 ` John W. Linville
2009-08-11 6:49 ` Roel Kluin
2009-08-11 18:25 ` John W. Linville [this message]
2009-08-20 14:52 ` John W. Linville
2009-08-24 23:34 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090811182514.GF2634@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=akpm@linux-foundation.org \
--cc=ath9k-devel@lists.ath9k.org \
--cc=jmalinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=m.sujith@gmail.com \
--cc=mcgrof@gmail.com \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).