From: Jouni Malinen <j@w1.fi>
To: Zhu Yi <yi.zhu@intel.com>
Cc: hostap@lists.shmoo.com, linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] nl80211 connect API support
Date: Thu, 13 Aug 2009 12:11:03 +0300 [thread overview]
Message-ID: <20090813091103.GA1826@jm.kir.nu> (raw)
In-Reply-To: <1250153731-17208-2-git-send-email-yi.zhu@intel.com>
On Thu, Aug 13, 2009 at 04:55:31PM +0800, Zhu Yi wrote:
> - * authenticate - Request driver to authenticate
> + * authenticate - Request driver to authenticate (deprecated)
> + * This is an optional function that to make compatibility for wireless
> + * stack that doesn't support connect API when driver SME is used
> + * (WPA_DRIVER_FLAGS_SME).
Thanks for the patch. If I understood this correctly, wpa_supplicant
would be converted to use the new connect command whenever it is
supported. While it is nice to get support for connect added, this is
not how it should be done as it breaks all the new work we have been
enabling with mac80211. The separate auth/assoc commands should be the
default operation and only if the driver does not support this, should
the connect command be used.
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2009-08-13 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 8:55 [PATCH] Fix cipher overwide problem for 802.1X WEP Zhu Yi
2009-08-13 8:55 ` [PATCH] nl80211 connect API support Zhu Yi
2009-08-13 9:11 ` Jouni Malinen [this message]
2009-08-13 9:29 ` Zhu Yi
2009-08-13 10:46 ` Jouni Malinen
2009-08-14 4:17 ` Zhu Yi
2009-08-14 5:50 ` Johannes Berg
2009-08-14 7:55 ` Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090813091103.GA1826@jm.kir.nu \
--to=j@w1.fi \
--cc=hostap@lists.shmoo.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).