From: "John W. Linville" <linville@tuxdriver.com>
To: Valdis.Kletnieks@vt.edu
Cc: Andrew Morton <akpm@linux-foundation.org>,
Zhu Yi <yi.zhu@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net
Subject: Re: [ipw3945-devel] mmotm0812 - something in linux-next killed iwl-3945.c
Date: Thu, 13 Aug 2009 13:28:19 -0400 [thread overview]
Message-ID: <20090813172819.GD2647@tuxdriver.com> (raw)
In-Reply-To: <19728.1250182794@turing-police.cc.vt.edu>
On Thu, Aug 13, 2009 at 12:59:54PM -0400, Valdis.Kletnieks@vt.edu wrote:
> Build bombs out:
>
> CC drivers/net/wireless/iwlwifi/iwl-3945.o
> drivers/net/wireless/iwlwifi/iwl-3945.c: In function 'iwl3945_pass_packet_to_mac80211':
> drivers/net/wireless/iwlwifi/iwl-3945.c:580: error: 'hdr' undeclared (first use in this function)
> drivers/net/wireless/iwlwifi/iwl-3945.c:580: error: (Each undeclared identifier is reported only once
> drivers/net/wireless/iwlwifi/iwl-3945.c:580: error: for each function it appears in.)
> make[1]: *** [drivers/net/wireless/iwlwifi/iwl-3945.o] Error 1
>
> due to this in linux-next.patch:
>
> index 46288e7..ae7f163 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> (skipping)
> @@ -577,7 +577,10 @@ static void iwl3945_pass_packet_to_mac80211(struct iwl_priv
> *priv,
> if (ieee80211_is_data(hdr->frame_control))
> priv->rxtxpackets += len;
> #endif
> - ieee80211_rx_irqsafe(priv->hw, rxb->skb, stats);
> + iwl_update_stats(priv, false, hdr->frame_control, len);
> +
> + memcpy(IEEE80211_SKB_RXCB(rxb->skb), stats, sizeof(*stats));
> + ieee80211_rx_irqsafe(priv->hw, rxb->skb);
> rxb->skb = NULL;
>
> Sorry, don't have a linux-next git tree, so no 'git blame' for what did it.
> Hopefully somebody recognizes their handiwork... ;)
I think this is the LEDS-related build failure, which already has a patch.
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-08-13 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 16:59 mmotm0812 - something in linux-next killed iwl-3945.c Valdis.Kletnieks
2009-08-13 17:28 ` John W. Linville [this message]
2009-08-13 18:19 ` [ipw3945-devel] " Valdis.Kletnieks
2009-08-14 4:19 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090813172819.GD2647@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).