archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <>
To: Larry Finger <>
Cc: Christian Lamparter <>,
	wireless <>
Subject: Re: [RFT] p54: implement rfkill
Date: Wed, 19 Aug 2009 10:41:46 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Aug 07, 2009 at 11:39:40AM -0500, Larry Finger wrote:
> John W. Linville wrote:
> > On Sun, Jul 19, 2009 at 11:54:15PM +0200, Christian Lamparter wrote:
> >> This patch gets rid of the deprecated radio_enabled
> >>
> >> fwio.c: In function ‘p54_setup_mac’:
> >> fwio.c:323: warning: ‘radio_enabled’ is deprecated (declared at include/net/mac80211.h:607)
> > 
> > Anyone had a chance to test this?  And report the results to Christian?
> Sorry - I missed this one.
> I just tested it. With the patch, the warning is removed. As far as
> system operation, the following is observed:
> 1. If b43 is loaded when using p54usb, then the hardware switch will
> kill operation. This behavior is the same with or without this patch.
> 2. If b43 is unloaded, then p54usb no longer follows the hardware
> switch, but operation can be killed with the rfkill user-space
> utility. Again, this behavior does not depend on the patch.
> Based on the code changes in the patch, it looks as if the radio is
> turned off when the device is blocked, but I have no way to test that.
> Christian - please add a
> Tested-by: Larry Finger <> to the patch and
> submit. This change should be in 2.6.32.
> Larry

Original patch lacks a Signed-off-by...

John W. Linville		Someday the world will need a hero, and you			might be all we have.  Be ready.

      reply	other threads:[~2009-08-19 14:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-19 21:54 [RFT] p54: implement rfkill Christian Lamparter
2009-08-07 15:36 ` John W. Linville
2009-08-07 16:39   ` Larry Finger
2009-08-19 14:41     ` John W. Linville [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).