From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.atheros.com ([12.36.123.2]:40342 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756066AbZHYT3n (ORCPT ); Tue, 25 Aug 2009 15:29:43 -0400 Received: from mail.atheros.com ([10.10.20.108]) by sidewinder.atheros.com for ; Tue, 25 Aug 2009 12:29:46 -0700 Date: Tue, 25 Aug 2009 12:29:44 -0700 From: "Luis R. Rodriguez" To: Richard Farina CC: Luis Rodriguez , "dwmw2@infradead.org" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH] atheros: add ar9170.fw 1-stage firmware Message-ID: <20090825192944.GB7357@mosca> References: <1250793627-22396-1-git-send-email-lrodriguez@atheros.com> <4A8DAD1D.7090608@gmail.com> <20090820202817.GB18102@mosca> <4A943AFE.1000500@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <4A943AFE.1000500@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Aug 25, 2009 at 12:26:54PM -0700, Richard Farina wrote: > Luis R. Rodriguez wrote: > > On Thu, Aug 20, 2009 at 01:07:57PM -0700, Richard Farina wrote: > > > >> Luis R. Rodriguez wrote: > >> > >>> This adds support for ar9170 for using a 1-stage firmware. > >>> This means only 1 firmware file is required. AVM Fritz > >>> devices require this. > >>> > >>> Signed-off-by: Luis R. Rodriguez > >>> --- > >>> > >>> Here is a resend, noticed today this wasn't yet in the tree. > >>> > >>> > >>> > >> Last I tested this firmware it didn't seem to function nearly as well as > >> the 2 stage firmware, and if present, the 1 stage overrides the 2 > >> stage. > >> > > > > Can you be more specific than that? > > > > > >> Is this an improved version? > >> > > > > No, it is the same firmware. > > > > > >> Does this work properly in your testing? > >> > > > > Works for me, and is also required for usage of AVM Fritz devices. > > > > > I apologize for my confusion. Since we spoke on irc I am now clear that > this specific ar9170 firmware is slightly different than the open source > one available in git and seems a bit more stable than the 2 stage I was > previously using. I have tested monitor mode and packet injection which > are the only things that interest me about this device at the moment and > both appear slightly more stable using the 1 stage firmware. Please do > add the firmware located at > http://www.kernel.org/pub/linux/kernel/people/mcgrof/firmware/ar9170/ar9170.fw > to the linux firmware git repo. I believe that it would be a benefit to > many. > > ACKED BY: Rick Farina > TESTED BY: Rick Farina > > On a similar note, the open firmware has had issues reported by many > with speed and stability so I wouldn't recommend using it yet, but this > is mostly based on the complaints I've heard rather than my own personal > testing so remember a grain of salt. Thanks for the clarification, yeah I do believe the open fw needs more work, the code base is the same though so it remains unclear what could be the issue. Anyway I'll push this through and if hopefully more interested people can work on the open fw. I'll respin with the WHENCE changed. Luis