From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: ben@decadent.org.uk
Cc: bzolnier@gmail.com, gregkh@suse.de,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rt28xx: Make PCI_{MAP,UNMAP}_SINGLE type-safe
Date: Mon, 29 Mar 2010 10:52:02 +0900 [thread overview]
Message-ID: <20100329105129Y.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <1269822285.8653.251.camel@localhost>
On Mon, 29 Mar 2010 01:24:45 +0100
Ben Hutchings <ben@decadent.org.uk> wrote:
> To avoid recurrence of bugs such as <http://bugs.debian.org/575726>,
> change the type of the first parameter to linux_pci_{map,unmap}_single()
> from void * to struct rt_rtmp_adapter *. Also do not define the macros
> PCI_{MAP,UNMAP}_SINGLE() when building the rt2870sta driver; they are
> not used and if they were that would be a bug.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> drivers/staging/rt2860/rt_linux.h | 14 +++++---------
> drivers/staging/rt2860/rt_pci_rbus.c | 12 ++++--------
> 2 files changed, 9 insertions(+), 17 deletions(-)
I think using dma_map_single directly instead of inventing a wrapper
function make the code more readable.
next prev parent reply other threads:[~2010-03-29 1:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.00.1003282040480.4731@ernie.pinecrest>
2010-03-29 0:09 ` [PATCH] rt2860sta: Fix argument to linux_pci_unmap_single() Ben Hutchings
2010-03-29 0:24 ` [PATCH] rt28xx: Make PCI_{MAP,UNMAP}_SINGLE type-safe Ben Hutchings
2010-03-29 1:52 ` FUJITA Tomonori [this message]
2010-03-29 1:58 ` Ben Hutchings
2010-03-29 2:04 ` FUJITA Tomonori
2010-04-28 18:19 ` drago01
2010-04-28 17:39 ` Greg KH
2010-03-29 20:41 ` patch rt2860sta-fix-argument-to-linux_pci_unmap_single.patch added to 2.6.32-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329105129Y.fujita.tomonori@lab.ntt.co.jp \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=ben@decadent.org.uk \
--cc=bzolnier@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).