linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now
       [not found]                 ` <20100329214009.804ec23f.wzajas@gmail.com>
@ 2010-03-29 22:20                   ` Luis R. Rodriguez
  2010-04-20 15:45                     ` John W. Linville
  0 siblings, 1 reply; 5+ messages in thread
From: Luis R. Rodriguez @ 2010-03-29 22:20 UTC (permalink / raw)
  To: Wiktor Zajas; +Cc: ath9k-devel, linux-wireless

On Mon, Mar 29, 2010 at 12:40:09PM -0700, Wiktor Zajas wrote:
> Thanks so much for this driver, it's working flawlessly. Only one minor problem
> was "Michael MIC failure detected", changing to AES helped.

Not sure if Sujith's patch posted yesterday would fix this.

> I don't know if what I've done is correct, in order to recognize my card
> (TL-WN422G v2) I've added "ATH9K_FW_USB_DEV(0x1006, "ar9271.fw")," to
> "ath9k_hif_usb_ids[]", and changed "#define AR9271_USB 0x9271" to
> "#define AR9271_USB 0x1006", is this the right thing to do ?

Sort of, try this patch:

From: Luis R. Rodriguez <lrodriguez@atheros.com>
Subject: [PATCH] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID

Reported-by: Wiktor Zajas <w.zajas@gmail.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
 drivers/net/wireless/ath/ath9k/hif_usb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
index fc4f6e8..a7664e4 100644
--- a/drivers/net/wireless/ath/ath9k/hif_usb.c
+++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
@@ -21,6 +21,7 @@
 
 static struct usb_device_id ath9k_hif_usb_ids[] = {
 	ATH9K_FW_USB_DEV(0x9271, "ar9271.fw"),
+	ATH9K_FW_USB_DEV(0x1006, "ar9271.fw"), /* TL-WN422G v2 */
 	{ },
 };
 
-- 
1.6.3.3


********************************************************************************
                            Git Achievement Unlocked!                            

                         Apprentice Archivist (Level 3)                         
 Prepare each commit with its patch in one file per commit with git format-patch 
********************************************************************************


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now
  2010-03-29 22:20                   ` [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now Luis R. Rodriguez
@ 2010-04-20 15:45                     ` John W. Linville
  2010-04-20 17:36                       ` Luis R. Rodriguez
  2010-04-21  2:08                       ` Sujith
  0 siblings, 2 replies; 5+ messages in thread
From: John W. Linville @ 2010-04-20 15:45 UTC (permalink / raw)
  To: Luis R. Rodriguez; +Cc: Wiktor Zajas, ath9k-devel, linux-wireless

On Mon, Mar 29, 2010 at 03:20:08PM -0700, Luis R. Rodriguez wrote:
> On Mon, Mar 29, 2010 at 12:40:09PM -0700, Wiktor Zajas wrote:
> > Thanks so much for this driver, it's working flawlessly. Only one minor problem
> > was "Michael MIC failure detected", changing to AES helped.
> 
> Not sure if Sujith's patch posted yesterday would fix this.
> 
> > I don't know if what I've done is correct, in order to recognize my card
> > (TL-WN422G v2) I've added "ATH9K_FW_USB_DEV(0x1006, "ar9271.fw")," to
> > "ath9k_hif_usb_ids[]", and changed "#define AR9271_USB 0x9271" to
> > "#define AR9271_USB 0x1006", is this the right thing to do ?
> 
> Sort of, try this patch:
> 
> From: Luis R. Rodriguez <lrodriguez@atheros.com>
> Subject: [PATCH] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID
> 
> Reported-by: Wiktor Zajas <w.zajas@gmail.com>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
>  drivers/net/wireless/ath/ath9k/hif_usb.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
> index fc4f6e8..a7664e4 100644
> --- a/drivers/net/wireless/ath/ath9k/hif_usb.c
> +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
> @@ -21,6 +21,7 @@
>  
>  static struct usb_device_id ath9k_hif_usb_ids[] = {
>  	ATH9K_FW_USB_DEV(0x9271, "ar9271.fw"),
> +	ATH9K_FW_USB_DEV(0x1006, "ar9271.fw"), /* TL-WN422G v2 */
>  	{ },
>  };

Any feedback on this?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now
  2010-04-20 15:45                     ` John W. Linville
@ 2010-04-20 17:36                       ` Luis R. Rodriguez
  2010-04-21  2:08                       ` Sujith
  1 sibling, 0 replies; 5+ messages in thread
From: Luis R. Rodriguez @ 2010-04-20 17:36 UTC (permalink / raw)
  To: John W. Linville, Stephen Chen, Sujith
  Cc: Luis Rodriguez, Wiktor Zajas, ath9k-devel, linux-wireless

On Tue, Apr 20, 2010 at 08:45:44AM -0700, John W. Linville wrote:
> On Mon, Mar 29, 2010 at 03:20:08PM -0700, Luis R. Rodriguez wrote:
> > On Mon, Mar 29, 2010 at 12:40:09PM -0700, Wiktor Zajas wrote:
> > > Thanks so much for this driver, it's working flawlessly. Only one minor problem
> > > was "Michael MIC failure detected", changing to AES helped.
> > 
> > Not sure if Sujith's patch posted yesterday would fix this.
> > 
> > > I don't know if what I've done is correct, in order to recognize my card
> > > (TL-WN422G v2) I've added "ATH9K_FW_USB_DEV(0x1006, "ar9271.fw")," to
> > > "ath9k_hif_usb_ids[]", and changed "#define AR9271_USB 0x9271" to
> > > "#define AR9271_USB 0x1006", is this the right thing to do ?
> > 
> > Sort of, try this patch:
> > 
> > From: Luis R. Rodriguez <lrodriguez@atheros.com>
> > Subject: [PATCH] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID
> > 
> > Reported-by: Wiktor Zajas <w.zajas@gmail.com>
> > Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> > ---
> >  drivers/net/wireless/ath/ath9k/hif_usb.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
> > index fc4f6e8..a7664e4 100644
> > --- a/drivers/net/wireless/ath/ath9k/hif_usb.c
> > +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
> > @@ -21,6 +21,7 @@
> >  
> >  static struct usb_device_id ath9k_hif_usb_ids[] = {
> >  	ATH9K_FW_USB_DEV(0x9271, "ar9271.fw"),
> > +	ATH9K_FW_USB_DEV(0x1006, "ar9271.fw"), /* TL-WN422G v2 */

This patch was wrong, Sujith was going to fix it, I think he sent
some followups. If not we'll take care of it.

  Luis

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now
  2010-04-20 15:45                     ` John W. Linville
  2010-04-20 17:36                       ` Luis R. Rodriguez
@ 2010-04-21  2:08                       ` Sujith
  2010-04-21 12:59                         ` John W. Linville
  1 sibling, 1 reply; 5+ messages in thread
From: Sujith @ 2010-04-21  2:08 UTC (permalink / raw)
  To: John W. Linville
  Cc: Luis Rodriguez, Wiktor Zajas, ath9k-devel, linux-wireless

John W. Linville wrote:
> Any feedback on this?

This has already been merged.

commit e92119ca88691ac2239916d31c3dcecd10867521
Author: Sujith <Sujith.Manoharan@atheros.com>
Date:   Thu Apr 1 10:28:24 2010 +0530

    ath9k_htc: Add TL-WN422G v2 product ID

    Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>


Sujith

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now
  2010-04-21  2:08                       ` Sujith
@ 2010-04-21 12:59                         ` John W. Linville
  0 siblings, 0 replies; 5+ messages in thread
From: John W. Linville @ 2010-04-21 12:59 UTC (permalink / raw)
  To: Sujith; +Cc: Luis Rodriguez, Wiktor Zajas, ath9k-devel, linux-wireless

On Wed, Apr 21, 2010 at 07:38:12AM +0530, Sujith wrote:
> John W. Linville wrote:
> > Any feedback on this?
> 
> This has already been merged.
> 
> commit e92119ca88691ac2239916d31c3dcecd10867521
> Author: Sujith <Sujith.Manoharan@atheros.com>
> Date:   Thu Apr 1 10:28:24 2010 +0530
> 
>     ath9k_htc: Add TL-WN422G v2 product ID
> 
>     Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
>     Signed-off-by: John W. Linville <linville@tuxdriver.com>

:-)  OK, thanks!

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-04-21 13:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <43e72e891003281631i52f2800k23581c055fbc32ac@mail.gmail.com>
     [not found] ` <43e72e891003281632x17f6d1d9i82640d96baa84096@mail.gmail.com>
     [not found]   ` <c13c21871003281831u74976d85lb3d4ece2d59c1f86@mail.gmail.com>
     [not found]     ` <43e72e891003281929hfff3821p65a9c42f15d9f6db@mail.gmail.com>
     [not found]       ` <c13c21871003281948y40edee0bi36c185b9dfaf4036@mail.gmail.com>
     [not found]         ` <43e72e891003282006l266141ehb78a2f4d46db76d6@mail.gmail.com>
     [not found]           ` <c13c21871003282118s80d7c8era5585af4a3377bc3@mail.gmail.com>
     [not found]             ` <c13c21871003282131x1ebaaee8h74f737c797b71b84@mail.gmail.com>
     [not found]               ` <19376.15678.641255.41127@gargle.gargle.HOWL>
     [not found]                 ` <20100329214009.804ec23f.wzajas@gmail.com>
2010-03-29 22:20                   ` [ath9k-devel] ath9k_htc: add the 0cf3:1006 TL-WN422G v2 device ID now Luis R. Rodriguez
2010-04-20 15:45                     ` John W. Linville
2010-04-20 17:36                       ` Luis R. Rodriguez
2010-04-21  2:08                       ` Sujith
2010-04-21 12:59                         ` John W. Linville

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).