linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Zidlicky <rz@linux-m68k.org>
To: Pavel Roskin <proski@gnu.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: rc80211_minstrel.c:70 WARNING with 2.6.34-rc4
Date: Mon, 19 Apr 2010 19:41:01 +0200	[thread overview]
Message-ID: <20100419174100.GA5312@linux-m68k.org> (raw)
In-Reply-To: <1271694855.9026.51.camel@mj>


Hi,

> > I am getting tons of these http://www.kerneloops.org/submitresult.php?number=3048061,
> > appears every packet triggers that.
> 
> The warning comes from the function rix_to_ndx() in rc80211_minstrel.c:
> 
> /* convert mac80211 rate index to local array index */
> static inline int
> rix_to_ndx(struct minstrel_sta_info *mi, int rix)
> {
>         int i = rix;
>         for (i = rix; i >= 0; i--)
>                 if (mi->r[i].rix == rix)
>                         break;
>         WARN_ON(i < 0);
>         return i;
> }
> 
> > Can provide lots of debugging info.
> 
> My impression is that WARN_ON is not warranted in that function, but it
> would be interesting to know how you got to that point.

I am using the rt73usb, WEP, adhoc, fixed rate(11M) on both ends:

wlan0     IEEE 802.11bg  ESSID:"XXXXXXXX"  
          Mode:Ad-Hoc  Frequency:2.442 GHz  Cell: F6:B2:CB:FC:62:6C   
          Tx-Power=20 dBm   
          Retry  long limit:7   RTS thr:off   Fragment thr:off
          Encryption key:  XXXXXXXXXX
          Power Management:on

It is 2.6.34-rc4, no compat-wireless.

As of unusual circumstances - the  rt73usb driver has some bug that causes
very high retransmit rates. On the opposite end the ath5k driver complains "cant
handle jumbo frames".
I had it perfectly working some time ago but need to figure out which off the many 
patches did it and apply it to the new kernel. 
This might stress minstrel more than needed but otoh it was my impression that the
warning was triggered by every single packet.

Let me know if you want any more info.

Richard

  reply	other threads:[~2010-04-19 17:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-18  8:56 rc80211_minstrel.c:70 WARNING with 2.6.34-rc4 Richard Zidlicky
2010-04-19 16:34 ` Pavel Roskin
2010-04-19 17:41   ` Richard Zidlicky [this message]
2010-04-19 17:41     ` Felix Fietkau
2010-04-19 17:55       ` Richard Zidlicky
2010-04-19 18:00         ` Felix Fietkau
2010-04-22 21:38           ` Pavel Roskin
2010-04-22 22:15             ` Richard Zidlicky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100419174100.GA5312@linux-m68k.org \
    --to=rz@linux-m68k.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).