From: Bob Copeland <me@bobcopeland.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
"Luis R. Rodriguez" <mcgrof@bombadil.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ath5k: disable ASPM
Date: Sat, 19 Jun 2010 08:38:41 -0400 [thread overview]
Message-ID: <20100619123841.GA31838@hash.localnet> (raw)
In-Reply-To: <1276933774.16697.11.camel@maxim-laptop>
On Sat, Jun 19, 2010 at 10:49:34AM +0300, Maxim Levitsky wrote:
> How this patch?
Looks fine to me. Some nitpicking below but feel free to add my
Acked-by: Bob Copeland <me@bobcopeland.com>
to this or a later version.
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
> Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
I believe maintaining the s-o-b is usually reserved for the case when the
patch only has minor edits; here your patch while same in spirit has
some 30 fewer lines. Maybe should use "From:" or mention Jussi in the
commit log to maintain attribution instead?
> + /* Disable PCIE ASPM L0S. It is never enabled by windows driver */
> + pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S);
> +
Would be good to expand this comment as to why (just copy another
sentence from the commit log or so).
> ret = pci_enable_device(pdev);
> if (ret) {
> dev_err(&pdev->dev, "can't enable device\n");
> @@ -722,6 +726,8 @@ static int ath5k_pci_resume(struct device *dev)
> struct ieee80211_hw *hw = pci_get_drvdata(pdev);
> struct ath5k_softc *sc = hw->priv;
>
> + pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S);
> +
Did you test that it did get lost over suspend/resume? A glance at
pci_save_pcie_state seems to indicate it's saved.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2010-06-19 12:45 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 10:09 [PATCH] ath5k: disable ASPM Jussi Kivilinna
2010-05-28 16:19 ` [ath5k-devel] " Pavel Roskin
2010-05-28 18:25 ` Jussi Kivilinna
2010-05-28 20:27 ` Pavel Roskin
2010-05-31 1:06 ` Bruno Randolf
2010-06-01 20:43 ` Luis R. Rodriguez
2010-05-28 17:40 ` Luis R. Rodriguez
2010-05-28 18:20 ` Jussi Kivilinna
2010-06-17 20:33 ` Maxim Levitsky
2010-06-18 8:20 ` Jussi Kivilinna
2010-06-18 9:09 ` [ath5k-devel] " RHS Linux User
2010-06-18 10:15 ` Maxim Levitsky
2010-06-18 10:49 ` Jussi Kivilinna
2010-06-18 11:05 ` Maxim Levitsky
2010-06-18 13:59 ` Bob Copeland
2010-06-18 14:11 ` Maxim Levitsky
2010-06-19 7:49 ` [PATCH v2] " Maxim Levitsky
2010-06-19 12:38 ` Bob Copeland [this message]
2010-06-19 13:02 ` Maxim Levitsky
2010-06-19 15:32 ` [PATCH v3] " Maxim Levitsky
2010-07-26 20:13 ` [ath5k-devel] " Luis R. Rodriguez
2010-07-26 20:49 ` Maxim Levitsky
2010-07-26 21:06 ` Luis R. Rodriguez
2010-07-26 21:14 ` Matthew Garrett
2010-07-26 22:20 ` Luis R. Rodriguez
2010-07-26 22:24 ` Matthew Garrett
2010-07-26 22:29 ` Luis R. Rodriguez
2010-07-26 21:17 ` Maxim Levitsky
2010-07-26 21:25 ` Matthew Garrett
2010-07-26 22:15 ` Luis R. Rodriguez
2010-07-26 22:21 ` Matthew Garrett
2010-07-26 22:26 ` Luis R. Rodriguez
2010-07-26 22:29 ` Matthew Garrett
2010-07-26 22:31 ` Luis R. Rodriguez
2010-07-26 22:33 ` Matthew Garrett
2010-07-26 22:43 ` Luis R. Rodriguez
2010-07-26 22:50 ` Matthew Garrett
2010-07-27 9:35 ` Maxim Levitsky
2010-07-27 15:57 ` Luis R. Rodriguez
2010-07-28 23:48 ` Maxim Levitsky
2010-07-29 0:06 ` Luis R. Rodriguez
2010-07-26 22:13 ` Luis R. Rodriguez
2010-07-26 22:56 ` Luis R. Rodriguez
2010-06-20 8:13 ` [ath5k-devel] [PATCH v2] " Luis R. Rodriguez
2010-06-20 11:18 ` Maxim Levitsky
2010-06-20 18:04 ` Maxim Levitsky
2010-06-21 5:53 ` Luis R. Rodriguez
2010-06-21 20:01 ` Jussi Kivilinna
2010-06-21 20:16 ` Maxim Levitsky
2010-06-21 20:33 ` Jussi Kivilinna
2010-06-21 20:39 ` Luis R. Rodriguez
2010-06-22 16:31 ` Matthew Garrett
2010-06-22 16:48 ` Luis R. Rodriguez
2010-06-22 16:52 ` Matthew Garrett
2010-06-22 17:17 ` Luis R. Rodriguez
2010-06-22 17:25 ` Matthew Garrett
2010-06-22 17:40 ` Luis R. Rodriguez
2010-06-22 17:50 ` Matthew Garrett
2010-06-22 18:28 ` Luis R. Rodriguez
2010-06-22 18:44 ` Matthew Garrett
2010-06-22 19:13 ` Luis R. Rodriguez
2010-06-22 19:31 ` Johannes Stezenbach
2010-06-22 19:37 ` Luis R. Rodriguez
2010-06-22 19:38 ` Luis R. Rodriguez
2010-06-23 14:39 ` Johannes Stezenbach
2010-06-23 16:28 ` Luis R. Rodriguez
2010-06-23 19:07 ` Johannes Stezenbach
2010-06-23 19:23 ` Johannes Stezenbach
2010-06-21 20:37 ` Luis R. Rodriguez
2010-06-21 23:55 ` Maxim Levitsky
2010-07-26 16:34 ` [PATCH] " Maxim Levitsky
2010-07-26 18:37 ` John W. Linville
2010-07-26 18:41 ` [ath5k-devel] " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100619123841.GA31838@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=mcgrof@bombadil.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).