From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
stable@kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [stable] [PATCH 1/4 2.6.33.y] mac80211: explicitly disable/enable QoS
Date: Wed, 28 Jul 2010 08:50:07 +0200 [thread overview]
Message-ID: <20100728085007.349b2c22@dhcp-lab-109.englab.brq.redhat.com> (raw)
In-Reply-To: <20100727235451.GA12332@kroah.com>
On Tue, 27 Jul 2010 16:54:51 -0700
Greg KH <greg@kroah.com> wrote:
> On Wed, Jul 28, 2010 at 12:15:25AM +0100, Ben Hutchings wrote:
> > On Tue, 2010-07-27 at 15:40 -0700, Greg KH wrote:
> > > On Mon, Jun 07, 2010 at 12:00:24PM +0200, Stanislaw Gruszka wrote:
> > > > commit e1b3ec1a2a336c328c336cfa5485a5f0484cc90d upstream.
> > > >
> > > > Add interface to disable/enable QoS (aka WMM or WME). Currently drivers
> > > > enable it explicitly when ->conf_tx method is called, and newer disable.
> > > > Disabling is needed for some APs, which do not support QoS, such
> > > > we should send QoS frames to them.
> > >
> > > Why is this a patch for a -stable tree? It looks like it adds a new api
> > > for a new feature, right?
> > [...]
> >
> > It extends the interface between the 802.11 stack and drivers so that
> > drivers can avoid sending QoS frames to APs that don't support them.
> > There is no new interface to userland. My understanding is that iwlwifi
> > becomes unable to communicate with non-QoS-capable APs after having once
> > associated with a QoS-capable AP, without this and the following change
> > in iwlwifi itself.
>
> Is this really true? And is it a bug that people are hitting?
Yes, without that patch iwlwifi devices are not able to connect with some
old APs. I had only two Fedora bug reports about that, so do not think
this is something critical. Fill free to drop that patch (together with
"iwlwifi: manage QoS by mac stack" which is part of the fix and do not have
sense alone), or apply only to 2.6.34.
Stanislaw
next prev parent reply other threads:[~2010-07-28 6:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 10:00 [PATCH 1/4 2.6.33.y] mac80211: explicitly disable/enable QoS Stanislaw Gruszka
2010-06-07 10:00 ` [PATCH 2/4 2.6.33.y] iwlwifi: manage QoS by mac stack Stanislaw Gruszka
2010-06-07 10:00 ` [PATCH 3/4 2.6.33.y] mac80211: do not wip out old supported rates Stanislaw Gruszka
2010-06-07 10:00 ` [PATCH 4/4 2.6.33.y] mac80211: fix supported rates IE if AP doesn't give us it's rates Stanislaw Gruszka
2010-07-27 22:40 ` [stable] [PATCH 1/4 2.6.33.y] mac80211: explicitly disable/enable QoS Greg KH
2010-07-27 23:15 ` Ben Hutchings
2010-07-27 23:54 ` Greg KH
2010-07-28 6:50 ` Stanislaw Gruszka [this message]
2010-07-29 21:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100728085007.349b2c22@dhcp-lab-109.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=ben@decadent.org.uk \
--cc=greg@kroah.com \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).