linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bruno Randolf <br1@einfach.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	lrodriguez@atheros.com, Felix Fietkau <nbd@openwrt.org>
Subject: Re: [PATCH v4 1/3] cfg80211: Add nl80211 antenna configuration
Date: Wed, 28 Jul 2010 11:03:44 +0900	[thread overview]
Message-ID: <201007281103.44963.br1@einfach.org> (raw)
In-Reply-To: <1280225142.19098.10.camel@jlt3.sipsolutions.net>

On Tue July 27 2010 19:05:42 you wrote:
> I'm still not convinced that this is the best approach. Can you discuss
> this a bit?

well... i am mainly concerned about what you call "legacy" hardware at the 
moment, but i am trying to make the API useful for 802.11n devices as well. 

first, thinking only about legacy devices with 2 antennas, the three most 
common settings are "fixed antenna 1", "fixed antenna 2" and "antenna 
diversity". luis suggested to use a simple value and constants for this, but i 
believe that this covers only 90% of the cases, the others being antenna 
setups i have described (in the commit message and per email before), which 
use a different antenna for TX than for RX, or diversity for RX and a single 
fixed antenna for TX. also, while not hugely popular or common, there *is* 
"legacy" hardware out there which has more than two antennas (e.g.: "pre-11n 
RangeMax" and "large phased array switch" which were based on ath5k chipsets) 
and at least the atheros eeprom supports more antennas. i'm not sure about 
other hardware, but i think it's good to have the flexibility to support more 
than two antennas in the API, also since this matches with what we need for 
802.11n. that's why a bitmask makes sense.

honestly, i don't know too much about 802.11n, so i need the help of people 
who work with 802.11n to see if this is useful for them and possibly extend 
it, or update the documentation to make the API more clear. but i believe that 
if you think 'chainmask' instead of 'antenna' it should be o.k...
in the end we are just talking about antennas :) for most of the users the 
antenna settings will just be default, but sometimes, especially in outdoor 
installations less antennas are present, or special setups can be desired and 
this API can be used to inform the HW about available antennas, wether it's 
802.11n or not. 

bruno

  reply	other threads:[~2010-07-28  2:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27  9:47 [PATCH v4 0/3] Antenna configuration Bruno Randolf
2010-07-27  9:48 ` [PATCH v4 1/3] cfg80211: Add nl80211 antenna configuration Bruno Randolf
2010-07-27 10:05   ` Johannes Berg
2010-07-28  2:03     ` Bruno Randolf [this message]
2010-07-27 16:19   ` Luis R. Rodriguez
2010-07-27 16:39     ` Felix Fietkau
2010-07-27 16:47       ` Luis R. Rodriguez
2010-07-28  2:06         ` Bruno Randolf
2010-07-28 17:24           ` Luis R. Rodriguez
2010-07-28 17:50             ` Felix Fietkau
2010-07-28 21:15               ` Luis R. Rodriguez
2010-07-28 21:26                 ` Felix Fietkau
2010-07-28 21:39                   ` Luis R. Rodriguez
2010-07-28 22:05                     ` Felix Fietkau
2010-07-28 22:14                       ` Luis R. Rodriguez
2010-07-29  0:10                       ` Luis R. Rodriguez
2010-07-29  2:11             ` Bruno Randolf
2010-07-29 15:09               ` Luis R. Rodriguez
2010-08-02  3:59                 ` Bruno Randolf
2010-08-02  5:31                   ` Luis R. Rodriguez
2010-07-27  9:48 ` [PATCH v4 2/3] mac80211: Add " Bruno Randolf
2010-07-27  9:48 ` [PATCH v4 3/3] ath5k: Add support for " Bruno Randolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201007281103.44963.br1@einfach.org \
    --to=br1@einfach.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).