From: Christian Lamparter <firstname.lastname@example.org>
To: "John W. Linville" <email@example.com>
Benoit Papillault <firstname.lastname@example.org>
Subject: Re: [PATCH] ar9170: add get_survey callback in order to get channel noise
Date: Wed, 28 Jul 2010 21:57:56 +0200 [thread overview]
Message-ID: <email@example.com> (raw)
On Wednesday 28 July 2010 21:15:53 John W. Linville wrote:
> On Wed, Jul 28, 2010 at 09:10:31PM +0200, Christian Lamparter wrote:
> > On Wednesday 28 July 2010 20:48:44 John W. Linville wrote:
> > > Signed-off-by: John W. Linville <firstname.lastname@example.org>
> > > ---
> > > drivers/net/wireless/ath/ar9170/main.c | 17 +++++++++++++++++
> > > 1 files changed, 17 insertions(+), 0 deletions(-)
> > > [...]
> > One problem: the noisefloor stays at the same level and
> > is not updated. You would have to call ar9170_set_channel,
> > but I don't recommend that because that may lockup
> > the device :(.
> I'm not sure I understand -- isn't ar9170_set_channel already called
> from ar9170_op_config? Or are you saying that the value will be
> stale unless you call ar9170_set_channel again?
the latter... come to think of it, I wrote a RFT a while back:
"[RFT] ar9170: implement get_survey" <- 27. April
and Benoit joined in to point out that he has/had the same
issue with ath9k hardware. Was this ever sorted out?
> How is this patch any worse than the situation was before commit
Well, a dodgy value is hardly an improvement, right?
Sure it is _just_ the noise *floor* and people
might argue that any value is better than nothing at all.
Acked-by: Christian Lamparter <email@example.com>
and add the nf-update to the TODO-list...
Or wait and look how ath9k(_htc) does/did it.
next prev parent reply other threads:[~2010-07-28 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 18:48 [PATCH] ar9170: add get_survey callback in order to get channel noise John W. Linville
2010-07-28 19:10 ` Christian Lamparter
2010-07-28 19:15 ` John W. Linville
2010-07-28 19:57 ` Christian Lamparter [this message]
2010-07-28 20:30 ` John W. Linville
2010-07-28 21:20 ` [PATCH v2] " John W. Linville
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).