From: Bruno Randolf <br1@einfach.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] iw: Add antenna configuration commands
Date: Thu, 29 Jul 2010 12:35:11 +0900 [thread overview]
Message-ID: <201007291235.11202.br1@einfach.org> (raw)
In-Reply-To: <201007281729.38652.br1@einfach.org>
On Wed July 28 2010 17:29:38 Bruno Randolf wrote:
> On Wed July 28 2010 15:50:48 Johannes Berg wrote:
> > On Wed, 2010-07-28 at 11:07 +0900, Bruno Randolf wrote:
> > > On Tue July 27 2010 19:04:21 Johannes Berg wrote:
> > > > On Tue, 2010-07-27 at 18:49 +0900, Bruno Randolf wrote:
> > > > > + if (tb_msg[NL80211_ATTR_WIPHY_ANTENNA_TX] &&
> > > > > + tb_msg[NL80211_ATTR_WIPHY_ANTENNA_RX]) {
> > > > > + printf("\tAntenna: TX %d RX %d\n",
> > > > > + nla_get_u8(tb_msg[NL80211_ATTR_WIPHY_ANTENNA_TX]),
> > > > > + nla_get_u8(tb_msg[NL80211_ATTR_WIPHY_ANTENNA_RX]));
> > > >
> > > > That's like the worst possible way to show the info.
> > >
> > > which way would you prefer?
> >
> > It occurred to me later that with the normal numbers we have (1 through
> > 7) it won't matter much ... but still, I'd prefer %#x.
>
> ok. changed that...
actually - no. what sense does it make to use a hexadecimal notation and print
0x for values between 0 and 7?
bruno
next prev parent reply other threads:[~2010-07-29 3:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 9:49 [PATCH 1/2] iw: Sync nl80211.h with wireless-testing Bruno Randolf
2010-07-27 9:49 ` [PATCH 2/2] iw: Add antenna configuration commands Bruno Randolf
2010-07-27 10:04 ` Johannes Berg
2010-07-28 2:07 ` Bruno Randolf
2010-07-28 6:50 ` Johannes Berg
2010-07-28 8:29 ` Bruno Randolf
2010-07-29 3:35 ` Bruno Randolf [this message]
2010-07-29 7:49 ` Johannes Berg
2010-07-29 9:14 ` Bruno Randolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007291235.11202.br1@einfach.org \
--to=br1@einfach.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).