From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Komuro <komurojun-mbn@nifty.com>
Cc: Michael Buesch <mb@bu3sch.de>,
netdev@vger.kernel.org, linux-pcmcia@lists.infradead.org,
linux-wireless@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 01/11] pcmcia: use pcmica_{read,write}_config_byte
Date: Mon, 2 Aug 2010 21:52:21 +0200 [thread overview]
Message-ID: <20100802195221.GA21063@comet.dominikbrodowski.net> (raw)
In-Reply-To: <15238373.192661280750366920.komurojun-mbn@nifty.com>
Hey,
On Mon, Aug 02, 2010 at 08:59:26PM +0900, Komuro wrote:
> >--- a/drivers/net/pcmcia/xirc2ps_cs.c
> >+++ b/drivers/net/pcmcia/xirc2ps_cs.c
>
>
> >+ if (err)
> > goto config_error;
> >- reg.Action = CS_WRITE;
> >- reg.Offset = CISREG_IOBASE_1;
> >- reg.Value = (link->io.BasePort2 >> 8) & 0xff;
> >- if ((err = pcmcia_access_configuration_register(link, ®)))
> >+
> >+ err = pcmcia_write_config_byte(link, CISREG_IOBASE_1,
> >+ link->io.BasePort2 & 0xff);
>
> It should be
>
> err = pcmcia_write_config_byte(link, CISREG_IOBASE_1,
> (link->io.BasePort2 >> 8) & 0xff);
>
Fixed, thanks.
Best,
Dominik
prev parent reply other threads:[~2010-08-02 20:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100801125749.GA2564@comet.dominikbrodowski.net>
2010-08-01 12:59 ` [PATCH 01/11] pcmcia: use pcmica_{read,write}_config_byte Dominik Brodowski
2010-08-01 12:59 ` [PATCH 04/11] pcmcia: do not use io_req_t after call to pcmcia_request_io() Dominik Brodowski
2010-08-01 18:04 ` Marcel Holtmann
2010-08-01 12:59 ` [PATCH 05/11] pcmcia: do not use io_req_t when calling pcmcia_request_io() Dominik Brodowski
2010-08-01 18:04 ` Marcel Holtmann
2010-08-01 12:59 ` [PATCH 07/11] pcmcia: remove memreq_t Dominik Brodowski
2010-08-01 12:59 ` [PATCH 08/11] pcmcia: use struct resource for PCMCIA devices, part 2 Dominik Brodowski
2010-08-01 12:59 ` [PATCH 11/11] pcmcia: do not request windows if you don't need to Dominik Brodowski
2010-08-02 11:59 ` [PATCH 01/11] pcmcia: use pcmica_{read,write}_config_byte Komuro
2010-08-02 19:52 ` Dominik Brodowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802195221.GA21063@comet.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=komurojun-mbn@nifty.com \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).