From: "John W. Linville" <email@example.com> To: Dan Williams <firstname.lastname@example.org> Cc: Johannes Berg <email@example.com>, firstname.lastname@example.org Subject: Re: [wt PATCH 0/5] libertas: make association work again Date: Wed, 4 Aug 2010 15:34:42 -0400 [thread overview] Message-ID: <20100804193442.GR17666@tuxdriver.com> (raw) In-Reply-To: <email@example.com> On Wed, Aug 04, 2010 at 02:15:46PM -0500, Dan Williams wrote: > On Wed, 2010-08-04 at 09:46 +0200, Johannes Berg wrote: > > On Wed, 2010-08-04 at 00:41 -0500, Dan Williams wrote: > > > On Fri, 2010-07-30 at 08:35 +0200, Johannes Berg wrote: > > > > On Thu, 2010-07-29 at 23:07 -0700, Dan Williams wrote: > > > > > This series makes libertas actually associate with APs after the > > > > > cfg80211 conversion. There was a pretty big TODO where if cfg80211 > > > > > didn't pass in the BSSID of the AP to associate with, then libertas > > > > > would fail because the firmware really, really, really wants a BSSID. > > > > > So lets do a scan to find that BSSID. The other notable change is > > > > > a fix to make sure all supported rates are included in the firmware's > > > > > association request, lack of which caused some APs to deny the attempt. > > > > > > > > I'm a bit tempted to say we could use the connect logic in cfg80211 to > > > > provide this? cfg80211 _already_ provides this if the hardware wants > > > > auth()/assoc() rather than connect() calls, so it seems fairly simple to > > > > also (optionally) do it here? > > > > > > Yeah, I thought about that too. Do you want me to work on that now > > > instead of letting this patch through? I can revert the relevant bits > > > of this later if that's acceptable too. > > > > Either way works for me since I don't care about any cruft in > > libertas ;) > > John, if you don't mind applying this patch I'll work on generic > scan-before-connect support in cfg80211 in a further patch series. OK...which of these need to be in 2.6.36? John -- John W. Linville Someday the world will need a hero, and you firstname.lastname@example.org might be all we have. Be ready.
next prev parent reply other threads:[~2010-08-04 19:44 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-07-30 6:07 Dan Williams 2010-07-30 6:11 ` [wt PATCH 1/5] libertas: get the right # of scanned BSSes Dan Williams 2010-07-30 6:12 ` [wt PATCH 2/5] libertas: better scan response debugging Dan Williams 2010-07-30 6:14 ` [wt PATCH 3/5] libertas: better association request debugging Dan Williams 2010-07-30 6:16 ` [wt PATCH 4/5] libertas: fix association with some APs by using extended rates Dan Williams 2010-07-30 6:18 ` [wt PATCH 5/5] libertas: scan before assocation if no BSSID was given Dan Williams 2010-07-30 6:37 ` Johannes Berg 2010-08-04 5:43 ` [wt PATCH 5/5 v2] " Dan Williams 2010-07-30 6:35 ` [wt PATCH 0/5] libertas: make association work again Johannes Berg 2010-07-31 13:54 ` Holger Schurig 2010-08-04 5:41 ` Dan Williams 2010-08-04 7:46 ` Johannes Berg 2010-08-04 19:15 ` Dan Williams 2010-08-04 19:34 ` John W. Linville [this message] 2010-08-05 17:27 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100804193442.GR17666@tuxdriver.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [wt PATCH 0/5] libertas: make association work again' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).