linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Haid <d.haid@gogi.tv>
To: linux-wireless@vger.kernel.org, Qasim Javed <qasimj@gmail.com>
Subject: Re: Capturing packets with bad FCS in monitor mode
Date: Fri, 6 Aug 2010 03:06:57 +0200	[thread overview]
Message-ID: <201008060306.57963.d.haid@gogi.tv> (raw)
In-Reply-To: <AANLkTikM_hyo71PyMLQ9z63FnOkusbKQb7OkRWfOvSTZ@mail.gmail.com>

> if (ah->opmode == NL80211_IFTYPE_MONITOR) {
>         if (rx_stats->rs_status &
>                 ~(ATH9K_RXERR_DECRYPT | ATH9K_RXERR_MIC |
>                 ATH9K_RXERR_CRC))
>         return false;
> 
> Clearly, this function will return false in case of a CRC error while
> receiving on a monitor interface.

Wait a moment, should it not be the other way around? ATH9K_RXERR_CRC
is removed from rx_stats->rs_status and the comment above
also says that DECRYPT and MIC errors are ignored normally, while
CRC is additionally ignored in monitor mode.

Are you 100% certain that you were able to receive corrupted
packets after removing ATH9K_RXERR_CRC above??

  parent reply	other threads:[~2010-08-06  1:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-05 14:14 Capturing packets with bad FCS in monitor mode Daniel Haid
2010-08-05 14:43 ` ABM Musa
2010-08-05 14:56   ` Johannes Berg
2010-08-05 16:19   ` Daniel Haid
2010-08-05 16:30     ` ABM Musa
2010-08-05 16:40       ` Daniel Haid
2010-08-05 16:50         ` ABM Musa
2010-08-05 22:58 ` Qasim Javed
2010-08-06  0:58   ` Daniel Haid
2010-08-06  1:06   ` Daniel Haid [this message]
2010-08-06 10:09   ` radiotap rate no longer supported in mac80211? Daniel Haid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008060306.57963.d.haid@gogi.tv \
    --to=d.haid@gogi.tv \
    --cc=linux-wireless@vger.kernel.org \
    --cc=qasimj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).