linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Meyer <thomas@m3y3r.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
	"linux-wireless" <linux-wireless@vger.kernel.org>,
	"Wey-Yi W Guy" <wey-yi.w.guy@intel.com>,
	"Zhao, Shanyu" <shanyu.zhao@intel.com>
Subject: Re: [PATCH 2.6.36] iwlwifi: fix locking assertions
Date: Fri, 6 Aug 2010 17:12:44 +0200	[thread overview]
Message-ID: <201008061712.44561.thomas@m3y3r.de> (raw)
In-Reply-To: <1281104273.3853.504.camel@jlt3.sipsolutions.net>

On Friday 06 August 2010 16:17:53 Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> spin_is_locked() can return zero on some (UP?)

Yes, this is an UP config.

> configurations because locks don't exist, and
> that causes an endless amount of warnings. Use
> lockdep_assert_held() instead, which has two
> advantages:
>  1) it verifies the current task is holding
>     the lock or mutex
>  2) it compiles away completely when lockdep
>     is not enabled
> 

After applying your patch the warnings in the kernel log are gone.

Thanks for the quick fix.

kind regards
thomas


      reply	other threads:[~2010-08-06 15:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-06 14:17 [PATCH 2.6.36] iwlwifi: fix locking assertions Johannes Berg
2010-08-06 15:12 ` Thomas Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008061712.44561.thomas@m3y3r.de \
    --to=thomas@m3y3r.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=shanyu.zhao@intel.com \
    --cc=wey-yi.w.guy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).