From: Bob Copeland <me@bobcopeland.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Wojciech Dubowik <dubowoj@neratec.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 8/9] ath5k: AHB port. Add AHB bus support.
Date: Sat, 13 Nov 2010 08:27:37 -0500 [thread overview]
Message-ID: <20101113132736.GA22348@hash.localnet> (raw)
In-Reply-To: <4CDD9BB8.1040305@openwrt.org>
On Fri, Nov 12, 2010 at 08:55:36PM +0100, Felix Fietkau wrote:
> On 2010-11-12 8:51 PM, Wojciech Dubowik wrote:
> >> Having both in the kernel is completely pointless. There are no
> >> devices
> >> that can support both, nor will there ever be.
> >
> > I agree. The only advantage would be that some of the typos and missing
> > functions in either of the files would be detected during compile time.
Compile-testing coverage is a fine reason to allow people to compile
both modules. Ok, I accept that it's a bit of a pain to create separate
modules, but can we at least do it like:
ath5k-$(CONFIG_ATH5K_PCI) += pci.o
ath5k-$(CONFIG_ATH5K_AHB) += ahb.o
and add the appropriate selects and mutual exclusion to the Kconfig?
Of course, that presupposes a Kconfig entry for CONFIG_ATHEROS_AR2316
where there is not one currently.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2010-11-13 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <22942120.791289486697022.JavaMail.wlan@CHBU500181>
2010-11-11 14:58 ` [PATCH 8/9] ath5k: AHB port. Add AHB bus support Wojciech Dubowik
2010-11-12 19:26 ` Bob Copeland
2010-11-12 19:36 ` Felix Fietkau
2010-11-12 19:51 ` Wojciech Dubowik
2010-11-12 19:55 ` Felix Fietkau
2010-11-13 13:27 ` Bob Copeland [this message]
[not found] <16168765.161289826231239.JavaMail.wlan@CHBU500181>
2010-11-15 13:16 ` Wojciech Dubowik
2010-11-15 15:07 ` Bob Copeland
[not found] <25235417.301289836112686.JavaMail.wlan@CHBU500181>
2010-11-15 15:49 ` Wojciech Dubowik
2010-11-15 16:37 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101113132736.GA22348@hash.localnet \
--to=me@bobcopeland.com \
--cc=dubowoj@neratec.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).