From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John W Linville <linville@tuxdriver.com>,
george0505@realtek.com, chaoming_li@realsil.com.cn,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/6] rtlwifi: Add usb driver
Date: Mon, 7 Feb 2011 16:07:56 +0100 [thread overview]
Message-ID: <20110207150755.GC2319@redhat.com> (raw)
In-Reply-To: <4d4eec04.v8FQZqbn2LYPF8zs%Larry.Finger@lwfinger.net>
On Sun, Feb 06, 2011 at 12:44:20PM -0600, Larry Finger wrote:
> +enum {
> + VENDOR_WRITE = 0x00,
> + VENDOR_READ = 0x01,
> +};
[snip]
> +static int _usbctrl_vendorreq_async(struct usb_device *udev, u8 request,
> + u16 value, u16 index, void *pdata,
> + u16 len, u8 requesttype)
> +{
It whould be better to leave old name and remove requesttype argument.
We never call _usbctrl_vendorreq_async with VENDOR_READ, and
_usbctrl_vendorreq_sync with VENDOR_WRITE.
If this is not preparation for future changes, that need to
cleaned up, and VENDOR_WRITE and VENDOR_READ definition removed at all.
> + wvalue = (u16)(addr&0x0000ffff);
wvalue = (u16) addr;
> +static void _rtl_usb_io_handler_release(struct ieee80211_hw *hw)
> +{
> + struct rtl_priv *rtlpriv = rtl_priv(hw);
> +
> + if (&rtlpriv->io)
How it can be NULL? :-) Perhaps this should be rtlpriv check?
> + /* TODO: think of race condition... */
[snip]
> + /* TODO: statistics */
[snip]
> +
[snip]
> + /* TODO: Shall I ignore error and keep issue other urbs? */
[snip]
> + /* TODO: reinsert skb to list or free the skb? */
[snip]
> + /* TODO: if usb suspend, we may queue the skb and wake device up.
> + * Then xmit.
> + * TODO: may change this statement and check all usb state */
Lots of TODO, is this code working? :-)
Is this driver for devices that are currently on the market,
or for future product? I have 3 Realtek dongles, but all works
only with staging driver ...
Stanislaw
next prev parent reply other threads:[~2011-02-07 15:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 18:44 [PATCH 2/6] rtlwifi: Add usb driver Larry Finger
2011-02-07 15:07 ` Stanislaw Gruszka [this message]
2011-02-07 15:12 ` Stanislaw Gruszka
2011-02-09 1:58 ` about Mac80211 scan issue 李朝明
2011-02-09 10:54 ` Stanislaw Gruszka
[not found] ` <B8DE8263FD784AC082CFDB7E9269BAEA@realsil.com.cn>
2011-02-10 7:41 ` 答复: " Stanislaw Gruszka
[not found] ` <39A39FA0AD1A481480DE0BD469AAA79E@realsil.com.cn>
2011-02-10 9:50 ` 答复: " Stanislaw Gruszka
[not found] ` <86D43C3FD69641C38E7144E721BCC5A6@realsil.com.cn>
2011-02-10 11:37 ` 答复: 答复: 答复: about Mac80211scan issue Stanislaw Gruszka
2011-02-11 2:26 ` [RFC] mac80211: cisco 1252 HT bw20, sta->ht_cap.cap bw is wrong 李朝明
2011-02-11 10:22 ` Stanislaw Gruszka
2011-02-12 3:32 ` [RFC] mac80211: mac80211's null packet issue 李朝明
2011-02-14 10:16 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207150755.GC2319@redhat.com \
--to=sgruszka@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=george0505@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).