linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karl Beldan <karl.beldan@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Felix Fietkau <nbd@openwrt.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Karl Beldan <karl.beldan@rivierawaves.com>
Subject: Re: [PATCH v2] mac80211: minstrel_ht: do not sample unsupported rates
Date: Mon, 11 Nov 2013 20:44:38 +0100	[thread overview]
Message-ID: <20131111194438.GB1684@magnum.frso.rivierawaves.com> (raw)
In-Reply-To: <1384184796.14334.33.camel@jlt4.sipsolutions.net>

On Mon, Nov 11, 2013 at 04:46:36PM +0100, Johannes Berg wrote:
> On Mon, 2013-11-11 at 13:10 +0100, Karl Beldan wrote:
> > From: Karl Beldan <karl.beldan@rivierawaves.com>
> > 
> > ATM minstrel_ht does not check whether a sampling rate is supported.
> > Unsupported rates attempts can trigger when there are holes in bitfields
> > of supported MCSes belonging to the same group (e.g many devices are
> > MCS32 capable without MCS33->39 capable, also we systematically have a
> > hole for CCK rates).
> > I originally replaced an unsupported sample index with the fls of the
> > bitfield of supported indexes of the sta current sample group, instead,
> > this change simply drops the sample attempt, as suggested by Felix.
> 
> That paragraph doesn't really belong here - you should describe what
> this change is doing (now). There may be some value in describing how
> you arrived at the solution, but this particular description seems
> unnecessary?
> 
Feel free to get rid of the superfluous comments.
 
Karl

  reply	other threads:[~2013-11-11 19:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-08 16:34 [PATCH 1/2] mac80211: minstrels: spare numerous useless calls to get_random_bytes Karl Beldan
2013-11-08 16:34 ` [PATCH 2/2] mac80211: minstrel_ht: do not sample unsupported rates Karl Beldan
2013-11-08 16:43   ` Felix Fietkau
2013-11-08 16:54     ` Karl Beldan
2013-11-11 12:10     ` [PATCH v2] " Karl Beldan
2013-11-11 15:46       ` Johannes Berg
2013-11-11 19:44         ` Karl Beldan [this message]
2013-11-08 16:39 ` [PATCH 1/2] mac80211: minstrels: spare numerous useless calls to get_random_bytes Felix Fietkau
2013-11-11 15:45 ` Johannes Berg
2013-11-11 19:43   ` Karl Beldan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131111194438.GB1684@magnum.frso.rivierawaves.com \
    --to=karl.beldan@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=karl.beldan@rivierawaves.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).