From: "John W. Linville" <linville@tuxdriver.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: David Herrmann <dh.herrmann@gmail.com>,
Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
ath9k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org,
Jouni Malinen <jouni@qca.qualcomm.com>,
"Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>
Subject: Re: [ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002
Date: Mon, 12 May 2014 13:49:10 -0400 [thread overview]
Message-ID: <20140512174910.GM17022@tuxdriver.com> (raw)
In-Reply-To: <536A9479.8010201@openwrt.org>
On Wed, May 07, 2014 at 10:15:53PM +0200, Felix Fietkau wrote:
> On 2014-05-07 21:54, John W. Linville wrote:
> > On Wed, May 07, 2014 at 09:22:58AM +0200, David Herrmann wrote:
> >> ah->caldata may be NULL if no channel is selected. Check for that before
> >> accessing it.
> >>
> >> Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
> >> ---
> >> Hi
> >>
> >> This is _definitely_ only a workaround, given that no-one guarantees ah->caldata
> >> is freed while we run in hw_per_calibration(). However, this patch fixes serious
> >> kernel panics with wifi-P2P on my machine.
> >>
> >> I'm not sure why ah->caldata can be NULL, but it definitely is. I think the
> >> correct fix would be to synchronously stop any running hw-calibration before
> >> setting ah->caldata to NULL. I don't know whether/where that is done, so I wrote
> >> this small workaround.
> >>
> >> Thanks
> >> David
> >
> > Is there any hope for getting a more complete fix from the ath9k guys
> > in short order?
> This looks easy to fix. I'll send a patch soon.
Ping?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2014-05-12 18:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 7:22 [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002 David Herrmann
2014-05-07 19:54 ` John W. Linville
2014-05-07 20:03 ` [ath9k-devel] " Luis R. Rodriguez
2014-05-07 20:38 ` John W. Linville
2014-05-07 20:15 ` Felix Fietkau
2014-05-12 17:49 ` John W. Linville [this message]
2014-05-12 18:43 ` Felix Fietkau
2014-05-13 6:50 ` David Herrmann
2014-05-13 9:00 ` Rajkumar Manoharan
2014-05-13 9:09 ` David Herrmann
2014-05-13 10:41 ` Rajkumar Manoharan
2014-05-13 18:21 ` David Herrmann
2014-05-08 18:18 ` Rajkumar Manoharan
2014-05-08 20:16 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512174910.GM17022@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=dh.herrmann@gmail.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@qca.qualcomm.com \
--cc=nbd@openwrt.org \
--cc=senthilb@qca.qualcomm.com \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).