linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Büsch" <m@bues.ch>
To: Larry Finger <Larry.Finger@lwfinger.net>,
	Chaoming Li <chaoming_li@realsil.com.cn>
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH] rtlwifi: Fix EFUSE_ANA8M map value
Date: Thu, 21 May 2015 21:44:21 +0200	[thread overview]
Message-ID: <20150521214421.15983b0a@milhouse> (raw)

[-- Attachment #1: Type: text/plain, Size: 2646 bytes --]

The map entry EFUSE_ANA8M is supposed to be a bit mask of the SYS_CLK register (see efuse.c)
It doesn't make sense to assign the enumeration value EFUSE_ANA8M. Assign the bitmask ANA8M instead.
rtl8192se does not have ANA8M, so use 0 as bitmask.

Signed-off-by: Michael Buesch <m@bues.ch>

---

This is RFC, because I don't really know the device.
The rtl8192se part of the patch is just a guess, because this driver's reg.h doesn't have an ANA8M define.

Index: wireless-drivers-next/drivers/net/wireless/rtlwifi/rtl8192ce/sw.c
===================================================================
--- wireless-drivers-next.orig/drivers/net/wireless/rtlwifi/rtl8192ce/sw.c
+++ wireless-drivers-next/drivers/net/wireless/rtlwifi/rtl8192ce/sw.c
@@ -282,7 +282,7 @@ static struct rtl_hal_cfg rtl92ce_hal_cf
 	.maps[EFUSE_PWC_EV12V] = PWC_EV12V,
 	.maps[EFUSE_FEN_ELDR] = FEN_ELDR,
 	.maps[EFUSE_LOADER_CLK_EN] = LOADER_CLK_EN,
-	.maps[EFUSE_ANA8M] = EFUSE_ANA8M,
+	.maps[EFUSE_ANA8M] = ANA8M,
 	.maps[EFUSE_HWSET_MAX_SIZE] = HWSET_MAX_SIZE,
 	.maps[EFUSE_MAX_SECTION_MAP] = EFUSE_MAX_SECTION,
 	.maps[EFUSE_REAL_CONTENT_SIZE] = EFUSE_REAL_CONTENT_LEN,
Index: wireless-drivers-next/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
===================================================================
--- wireless-drivers-next.orig/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
+++ wireless-drivers-next/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
@@ -206,7 +206,7 @@ static struct rtl_hal_cfg rtl92cu_hal_cf
 	.maps[EFUSE_PWC_EV12V] = PWC_EV12V,
 	.maps[EFUSE_FEN_ELDR] = FEN_ELDR,
 	.maps[EFUSE_LOADER_CLK_EN] = LOADER_CLK_EN,
-	.maps[EFUSE_ANA8M] = EFUSE_ANA8M,
+	.maps[EFUSE_ANA8M] = ANA8M,
 	.maps[EFUSE_HWSET_MAX_SIZE] = HWSET_MAX_SIZE,
 	.maps[EFUSE_MAX_SECTION_MAP] = EFUSE_MAX_SECTION,
 	.maps[EFUSE_REAL_CONTENT_SIZE] = EFUSE_REAL_CONTENT_LEN,
Index: wireless-drivers-next/drivers/net/wireless/rtlwifi/rtl8192se/sw.c
===================================================================
--- wireless-drivers-next.orig/drivers/net/wireless/rtlwifi/rtl8192se/sw.c
+++ wireless-drivers-next/drivers/net/wireless/rtlwifi/rtl8192se/sw.c
@@ -330,7 +330,7 @@ static struct rtl_hal_cfg rtl92se_hal_cf
 	.maps[EFUSE_PWC_EV12V] = 0, /* nouse for 8192se */
 	.maps[EFUSE_FEN_ELDR] = 0, /* nouse for 8192se */
 	.maps[EFUSE_LOADER_CLK_EN] = 0,/* nouse for 8192se */
-	.maps[EFUSE_ANA8M] = EFUSE_ANA8M,
+	.maps[EFUSE_ANA8M] = 0, /* nouse for 8192se */
 	.maps[EFUSE_HWSET_MAX_SIZE] = HWSET_MAX_SIZE_92S,
 	.maps[EFUSE_MAX_SECTION_MAP] = EFUSE_MAX_SECTION,
 	.maps[EFUSE_REAL_CONTENT_SIZE] = EFUSE_REAL_CONTENT_LEN,

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

             reply	other threads:[~2015-05-21 20:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 19:44 Michael Büsch [this message]
2015-05-21 21:54 ` [PATCH] rtlwifi: Fix EFUSE_ANA8M map value Larry Finger
2015-05-22  5:00   ` Michael Büsch
2015-05-22 20:21     ` Larry Finger
2015-05-22 21:13       ` Michael Büsch
2015-05-23  5:15         ` Larry Finger
2015-05-23 10:40           ` Michael Büsch
2015-05-23 18:01             ` Michael Büsch
2015-05-25 16:10               ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150521214421.15983b0a@milhouse \
    --to=m@bues.ch \
    --cc=Larry.Finger@lwfinger.net \
    --cc=chaoming_li@realsil.com.cn \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).