From: Samuel Ortiz <sameo@linux.intel.com>
To: Shikha Singh <shikha.singh@st.com>
Cc: aloisio.almeida@openbossa.org, lauro.venancio@openbossa.org,
linux-wireless@vger.kernel.org, linux-nfc@lists.01.org,
raunaque.quaiser@st.com, manoj.kumar@st.com,
sylvain.fidelis@st.com, patrick.sohn@st.com,
MMS_MMY_Applications_SW@list.st.com
Subject: Re: [[linux-nfc] PATCH v5 2/3] driver: nfc: Add ST95HF NFC Transceiver support
Date: Sun, 20 Dec 2015 18:50:53 +0100 [thread overview]
Message-ID: <20151220175053.GA4772@zurbaran.home> (raw)
In-Reply-To: <1448019621-14259-3-git-send-email-shikha.singh@st.com>
Hi Singh,
This looks a lot better than the initial version.
I only have one question:
On Fri, Nov 20, 2015 at 06:40:20AM -0500, Shikha Singh wrote:
> +/*
> + * st95hf_send_recv_cmd() is for sending commands to ST95HF
> + * that are described in the cmd_array[]. It can optionally
> + * receive the response if the cmd request is of type
> + * SYNC. For that to happen caller must pass true to recv_res.
> + * For ASYNC request, recv_res is ignored and the
> + * function will never try to receive the response on behalf
> + * of the caller.
> + */
> +static int st95hf_send_recv_cmd(struct st95hf_context *st95context,
> + enum st95hf_cmd_list cmd,
> + int no_modif,
> + struct param_list *list_array,
> + bool recv_res)
> +{
> + unsigned char spi_cmd_buffer[MAX_CMD_LEN];
> + int i, ret;
> + struct device *dev = &st95context->spicontext.spidev->dev;
How do you know this driver is still valid at that point ?
It seems to be a potential corner case against the driver's remove
function, but it seems to be a race nevertheless.
Cheers,
Samuel.
next prev parent reply other threads:[~2015-12-20 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 11:40 [[linux-nfc] PATCH v5 0/3] *** ST95HF driver v5 *** Shikha Singh
2015-11-20 11:40 ` [[linux-nfc] PATCH v5 1/3] NFC: digital: Add Type4A tags support Shikha Singh
2015-11-20 11:40 ` [[linux-nfc] PATCH v5 2/3] driver: nfc: Add ST95HF NFC Transceiver support Shikha Singh
2015-12-20 17:50 ` Samuel Ortiz [this message]
2015-12-21 11:57 ` Shikha SINGH
2015-12-21 22:45 ` Samuel Ortiz
2015-12-21 23:26 ` [linux-nfc] [ " Samuel Ortiz
2015-11-20 11:40 ` [[linux-nfc] PATCH v5 3/3] DT: bindings: net: nfc: Add ST95HF binding doc Shikha Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151220175053.GA4772@zurbaran.home \
--to=sameo@linux.intel.com \
--cc=MMS_MMY_Applications_SW@list.st.com \
--cc=aloisio.almeida@openbossa.org \
--cc=lauro.venancio@openbossa.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=manoj.kumar@st.com \
--cc=patrick.sohn@st.com \
--cc=raunaque.quaiser@st.com \
--cc=shikha.singh@st.com \
--cc=sylvain.fidelis@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).