linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: kvalo@codeaurora.org
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
	Ping-Ke Shih <pkshih@realtek.com>, shaofu <shaofu@realtek.com>,
	Larry Finger <Larry.Finger@lwfinger.net>
Subject: [PATCH 02/14] rtlwifi: Fix programing CAM content sequence.
Date: Thu,  1 Dec 2016 19:48:21 -0600	[thread overview]
Message-ID: <20161202014833.6856-3-Larry.Finger@lwfinger.net> (raw)
In-Reply-To: <20161202014833.6856-1-Larry.Finger@lwfinger.net>

From: Ping-Ke Shih <pkshih@realtek.com>

There is a potential race condition when the control byte of a CAM
entry is written first. Write in reverse order to correct the condition.

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: shaofu <shaofu@realtek.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
 drivers/net/wireless/realtek/rtlwifi/cam.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/cam.c b/drivers/net/wireless/realtek/rtlwifi/cam.c
index 8fe8b4c..5d58ec0 100644
--- a/drivers/net/wireless/realtek/rtlwifi/cam.c
+++ b/drivers/net/wireless/realtek/rtlwifi/cam.c
@@ -45,12 +45,13 @@ static void rtl_cam_program_entry(struct ieee80211_hw *hw, u32 entry_no,
 
 	u32 target_command;
 	u32 target_content = 0;
-	u8 entry_i;
+	s8 entry_i;
 
 	RT_PRINT_DATA(rtlpriv, COMP_SEC, DBG_DMESG, "Key content :",
 		      key_cont_128, 16);
 
-	for (entry_i = 0; entry_i < CAM_CONTENT_COUNT; entry_i++) {
+	/* 0-1 config + mac, 2-5 fill 128key,6-7 are reserved */
+	for (entry_i = CAM_CONTENT_COUNT - 1; entry_i >= 0; entry_i--) {
 		target_command = entry_i + CAM_CONTENT_COUNT * entry_no;
 		target_command = target_command | BIT(31) | BIT(16);
 
@@ -102,7 +103,6 @@ static void rtl_cam_program_entry(struct ieee80211_hw *hw, u32 entry_no,
 					target_content);
 			rtl_write_dword(rtlpriv, rtlpriv->cfg->maps[RWCAM],
 					target_command);
-			udelay(100);
 
 			RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD,
 				 "WRITE A4: %x\n", target_content);
-- 
2.10.2

  parent reply	other threads:[~2016-12-02  1:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02  1:48 [PATCH 00/14] rtlwifi: Various updates Larry Finger
2016-12-02  1:48 ` [PATCH 01/14] rtlwifi: Correct power save capability while init mac80211 Larry Finger
2016-12-30 13:10   ` [01/14] " Kalle Valo
2016-12-02  1:48 ` Larry Finger [this message]
2016-12-05 20:49   ` [PATCH 02/14] rtlwifi: Fix programing CAM content sequence Dan Carpenter
2016-12-02  1:48 ` [PATCH 03/14] rtlwifi: Set retry limit depends on vif type Larry Finger
2016-12-02  1:48 ` [PATCH 03/14] rtlwifi: extend debug_comp to u64 Larry Finger
2016-12-02  1:48 ` [PATCH 05/14] rtlwifi: Add TX report and disable key will wait until report acked Larry Finger
2016-12-05 21:10   ` Dan Carpenter
2016-12-02  1:48 ` [PATCH 06/14] rtlwifi: rtl8723be: btcoexist: Add single_ant_path Larry Finger
2016-12-02  1:48 ` [PATCH 07/14] rtlwifi: move btcoex's ant_num declaration Larry Finger
2016-12-02  1:48 ` [PATCH 08/14] rtlwifi: rtl8723be: btcoex: add package_type function to btcoex Larry Finger
2016-12-02  1:48 ` [PATCH 09/14] rtlwifi: ibtcoex: move bt_type declaration Larry Finger
2016-12-02  1:48 ` [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex Larry Finger
2016-12-05 21:34   ` Dan Carpenter
2016-12-05 22:34     ` Larry Finger
2016-12-06  7:13       ` Greg KH
2016-12-07 12:16         ` Kalle Valo
2016-12-07 13:32           ` Dan Carpenter
2016-12-07 16:41             ` Larry Finger
2016-12-08 11:43             ` Kalle Valo
2016-12-08 11:50               ` Dan Carpenter
2016-12-08 11:54                 ` Dan Carpenter
2016-12-09  8:50                   ` Kalle Valo
2016-12-09 23:56                     ` Markus Böhme
2016-12-10  6:39                       ` Joe Perches
2016-12-09  8:48                 ` Kalle Valo
2016-12-06 19:37       ` Dan Carpenter
2016-12-02  1:48 ` [PATCH 11/14] rtlwifi: Add a new enumeration value to btc_set_type Larry Finger
2016-12-02  1:48 ` [PATCH 12/14] rtlwifi: btcoexist: Add vendor definition for new btcoexist Larry Finger
2016-12-02  1:48 ` [PATCH 13/14] rtlwifi: rtl8723be: fix ant_sel code Larry Finger
2016-12-02  1:48 ` [PATCH 14/14] rtlwifi: Add work queue for c2h cmd Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161202014833.6856-3-Larry.Finger@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=shaofu@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).