linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Daniel Golle <daniel@makrotopia.org>
Cc: linux-wireless@vger.kernel.org,
	Johannes Berg <johannes@sipsolutions.net>,
	roman@advem.lv, michel.stempin@wanadoo.fr, c.mignanti@gmail.com,
	evaxige@qq.com, Kalle Valo <kvalo@codeaurora.org>,
	Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
	Gabor Juhos <juhosg@openwrt.org>
Subject: Re: [PATCH v2 14/14] rt2x00: add support for RT5350 WiSoC
Date: Mon, 16 Jan 2017 11:17:44 +0100	[thread overview]
Message-ID: <20170116101743.GF6968@redhat.com> (raw)
In-Reply-To: <20170116031734.GA32321@makrotopia.org>

On Mon, Jan 16, 2017 at 04:17:58AM +0100, Daniel Golle wrote:
> @@ -7131,6 +7236,12 @@ static int rt2800_validate_eeprom(struct rt2x00_dev *rt2x00dev)
>  		rt2x00_set_field16(&word, EEPROM_NIC_CONF0_RF_TYPE, RF2820);
>  		rt2800_eeprom_write(rt2x00dev, EEPROM_NIC_CONF0, word);
>  		rt2x00_eeprom_dbg(rt2x00dev, "Antenna: 0x%04x\n", word);
> +	} else if (rt2x00_rt(rt2x00dev, RT5350)) {
> +		rt2x00_set_field16(&word, EEPROM_NIC_CONF0_RXPATH, 1);
> +		rt2x00_set_field16(&word, EEPROM_NIC_CONF0_TXPATH, 1);
> +		rt2x00_set_field16(&word, EEPROM_NIC_CONF0_RF_TYPE, RF3320);

Here you set RF3320 ..
> +		rt2x00_eeprom_write(rt2x00dev, EEPROM_NIC_CONF0, word);
> +		rt2x00_eeprom_dbg(rt2x00dev, "Antenna: 0x%04x\n", word);
>  	} else if (rt2x00_rt(rt2x00dev, RT2860) ||
>  		   rt2x00_rt(rt2x00dev, RT2872)) {
>  		/*
> @@ -7265,6 +7376,8 @@ static int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
>  		rt2800_eeprom_read(rt2x00dev, EEPROM_CHIP_ID, &rf);
>  	else if (rt2x00_rt(rt2x00dev, RT3352))
>  		rf = RF3322;
> +	else if (rt2x00_rt(rt2x00dev, RT5350))
> +		rf = RF5350;

and here RF5350. This does not seems to be correct.

Stanislaw

  reply	other threads:[~2017-01-16 10:20 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13 21:20 [PATCH 04/40] rt2x00: rt2800lib: fix beacon generation on RT3593 Daniel Golle
2017-01-14 17:00 ` Kalle Valo
2017-01-16  2:53   ` [PATCH v2 00/14] rt2x00 patches from OpenWrt.org Daniel Golle
2017-01-16  2:55   ` [PATCH v2 01/14] rt2x00: rt2800lib: move rt2800_drv_data declaration into rt2800lib.h Daniel Golle
2017-01-28  8:48     ` [v2, " Kalle Valo
2017-01-16  2:55   ` [PATCH v2 02/14] rt2x00: rt2800lib: introduce RT2800_HAS_HIGH_SHARED_MEM flag Daniel Golle
2017-01-16  2:58   ` [PATCH v2 03/14] rt2x00: rt2800: serialize shared memory access Daniel Golle
2017-01-16  3:01   ` [PATCH v2 04/14] rt2x00: rt2800lib: fix beacon generation on RT3593 Daniel Golle
2017-01-16 10:04     ` Stanislaw Gruszka
2017-01-16  3:02   ` [PATCH v2 05/14] rt2x00: rt2800lib: add hw_beacon_count field to struct rt2800_drv_data Daniel Golle
2017-01-16  3:03   ` [PATCH v2 06/14] rt2x00: rt2800lib: init additional beacon offset registers Daniel Golle
2017-01-16  3:03   ` [PATCH v2 07/14] rt2x00: rt2800lib: fix max supported beacon count for RT3593 Daniel Golle
2017-01-16  3:05   ` [PATCH v2 08/14] rt2x00: rt2800mmio: add a workaround for spurious TX_FIFO_STATUS interrupts Daniel Golle
2017-01-18 14:44     ` Stanislaw Gruszka
2017-01-18 15:13       ` Stanislaw Gruszka
2017-01-16  3:06   ` [PATCH v2 09/14] rt2x00: rt2x00pci: set PCI MWI only if supported Daniel Golle
2017-01-16 10:08     ` Stanislaw Gruszka
2017-01-17  1:56       ` Daniel Golle
2017-01-17  7:34         ` John Crispin
2017-01-16  3:08   ` [PATCH v2 10/14] rt2x00: rt2800lib: correctly set HT20/HT40 filter Daniel Golle
2017-01-16 10:12     ` Stanislaw Gruszka
2017-01-19 12:49     ` [v2,10/14] " Kalle Valo
2017-01-16  3:13   ` [PATCH v2 11/14] rt2x00: rt2800lib: fix rf id for RT3352 Daniel Golle
2017-01-16 10:12     ` Stanislaw Gruszka
2017-01-16  3:14   ` [PATCH v2 12/14] rt2x00: rt2800lib: support for for RT3352 with external PA Daniel Golle
2017-01-16 10:14     ` Stanislaw Gruszka
2017-01-16  3:15   ` [PATCH v2 13/14] rt2x00: rt2800lib: add support for RT3352 with 20MHz crystal Daniel Golle
2017-01-18 14:30     ` Stanislaw Gruszka
2017-01-19 13:30       ` Daniel Golle
2017-01-19 20:52         ` Daniel Golle
2017-01-19 23:42       ` [PATCH v3] " Daniel Golle
2017-01-20 13:16         ` Stanislaw Gruszka
2017-01-16  3:17   ` [PATCH v2 14/14] rt2x00: add support for RT5350 WiSoC Daniel Golle
2017-01-16 10:17     ` Stanislaw Gruszka [this message]
2017-01-17  1:48       ` Daniel Golle
2017-01-18 14:47         ` Stanislaw Gruszka
2017-01-19 13:38           ` [PATCH v3] " Daniel Golle
2017-01-19 19:08             ` Kalle Valo
2017-01-19 20:37               ` Daniel Golle
2017-01-20  2:21             ` kbuild test robot
2017-01-20 13:19             ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170116101743.GF6968@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=c.mignanti@gmail.com \
    --cc=daniel@makrotopia.org \
    --cc=evaxige@qq.com \
    --cc=johannes@sipsolutions.net \
    --cc=john@phrozen.org \
    --cc=juhosg@openwrt.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michel.stempin@wanadoo.fr \
    --cc=nbd@nbd.name \
    --cc=roman@advem.lv \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).