From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-wireless@vger.kernel.org,
Christophe Ricard <christophe.ricard@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 2/6] NFC: st21nfca: Fix typo in copy pasted macro
Date: Tue, 7 Mar 2017 12:13:57 +0200 [thread overview]
Message-ID: <20170307101401.23182-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20170307101401.23182-1-andriy.shevchenko@linux.intel.com>
Seems this driver has never been even compile tested.
Fix obvious typo in macro to make it defined.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/nfc/st21nfca/i2c.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c
index 737384d287aa..7f68a5fe15d8 100644
--- a/drivers/nfc/st21nfca/i2c.c
+++ b/drivers/nfc/st21nfca/i2c.c
@@ -286,7 +286,7 @@ static int check_crc(u8 *buf, int buflen)
crc = ~crc;
if (buf[buflen - 2] != (crc & 0xff) || buf[buflen - 1] != (crc >> 8)) {
- pr_err(ST21NFCA_HCI_DRIVER_NAME
+ pr_err(ST21NFCA_HCI_I2C_DRIVER_NAME
": CRC error 0x%x != 0x%x 0x%x\n", crc, buf[buflen - 1],
buf[buflen - 2]);
@@ -672,7 +672,7 @@ static int st21nfca_hci_i2c_probe(struct i2c_client *client,
r = devm_request_threaded_irq(&client->dev, client->irq, NULL,
st21nfca_hci_irq_thread_fn,
phy->irq_polarity | IRQF_ONESHOT,
- ST21NFCA_HCI_DRIVER_NAME, phy);
+ ST21NFCA_HCI_I2C_DRIVER_NAME, phy);
if (r < 0) {
nfc_err(&client->dev, "Unable to register IRQ handler\n");
return r;
@@ -701,7 +701,7 @@ static int st21nfca_hci_i2c_remove(struct i2c_client *client)
}
static struct i2c_device_id st21nfca_hci_i2c_id_table[] = {
- {ST21NFCA_HCI_DRIVER_NAME, 0},
+ {ST21NFCA_HCI_I2C_DRIVER_NAME, 0},
{}
};
MODULE_DEVICE_TABLE(i2c, st21nfca_hci_i2c_id_table);
--
2.11.0
next prev parent reply other threads:[~2017-03-07 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 10:13 [PATCH v1 1/6] NFC: st21nfca: Fix obvious typo when check error code Andy Shevchenko
2017-03-07 10:13 ` Andy Shevchenko [this message]
2017-03-07 10:19 ` [PATCH v1 2/6] NFC: st21nfca: Fix typo in copy pasted macro Andy Shevchenko
2017-03-07 10:13 ` [PATCH v1 3/6] NFC: st21nfca: Get rid of platform data Andy Shevchenko
2017-03-07 10:13 ` [PATCH v1 4/6] NFC: st21nfca: Get rid of "interesting" use of interrupt polarity Andy Shevchenko
2017-03-07 10:14 ` [PATCH v1 5/6] NFC: st21nfca: Covert to use GPIO descriptor Andy Shevchenko
2017-03-07 10:14 ` [PATCH v1 6/6] NFC: st21nfca: Use unified device property API meaningfully Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307101401.23182-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=aloisio.almeida@openbossa.org \
--cc=christophe.ricard@gmail.com \
--cc=lauro.venancio@openbossa.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).