From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-wireless@vger.kernel.org,
Christophe Ricard <christophe.ricard@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 3/5] NFC: st21nfca: Get rid of "interesting" use of interrupt polarity
Date: Tue, 7 Mar 2017 12:25:44 +0200 [thread overview]
Message-ID: <20170307102546.32224-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20170307102546.32224-1-andriy.shevchenko@linux.intel.com>
I2C framework followed by IRQ framework does set interrupt polarity
correctly if it's properly specified in firmware (ACPI or DT).
Get rid of the redundant trick when requesting interrupt.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/nfc/st21nfca/i2c.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c
index 1eb558f00290..30ef330c9030 100644
--- a/drivers/nfc/st21nfca/i2c.c
+++ b/drivers/nfc/st21nfca/i2c.c
@@ -69,7 +69,6 @@ struct st21nfca_i2c_phy {
struct nfc_hci_dev *hdev;
unsigned int gpio_ena;
- unsigned int irq_polarity;
struct st21nfca_se_status se_status;
@@ -521,8 +520,6 @@ static int st21nfca_hci_i2c_acpi_request_resources(struct i2c_client *client)
phy->gpio_ena = desc_to_gpio(gpiod_ena);
- phy->irq_polarity = irq_get_trigger_type(client->irq);
-
phy->se_status.is_ese_present = false;
phy->se_status.is_uicc_present = false;
@@ -567,8 +564,6 @@ static int st21nfca_hci_i2c_of_request_resources(struct i2c_client *client)
phy->gpio_ena = gpio;
- phy->irq_polarity = irq_get_trigger_type(client->irq);
-
phy->se_status.is_ese_present =
of_property_read_bool(pp, "ese-present");
phy->se_status.is_uicc_present =
@@ -631,7 +626,7 @@ static int st21nfca_hci_i2c_probe(struct i2c_client *client,
r = devm_request_threaded_irq(&client->dev, client->irq, NULL,
st21nfca_hci_irq_thread_fn,
- phy->irq_polarity | IRQF_ONESHOT,
+ IRQF_ONESHOT,
ST21NFCA_HCI_DRIVER_NAME, phy);
if (r < 0) {
nfc_err(&client->dev, "Unable to register IRQ handler\n");
--
2.11.0
next prev parent reply other threads:[~2017-03-07 11:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 10:25 [PATCH v2 1/5] NFC: st21nfca: Fix obvious typo when check error code Andy Shevchenko
2017-03-07 10:25 ` [PATCH v2 2/5] NFC: st21nfca: Get rid of platform data Andy Shevchenko
2017-03-07 10:25 ` Andy Shevchenko [this message]
2017-03-07 10:25 ` [PATCH v2 4/5] NFC: st21nfca: Covert to use GPIO descriptor Andy Shevchenko
2017-03-07 10:25 ` [PATCH v2 5/5] NFC: st21nfca: Use unified device property API meaningfully Andy Shevchenko
2017-03-17 15:49 ` [PATCH v2 1/5] NFC: st21nfca: Fix obvious typo when check error code Andy Shevchenko
2017-03-21 2:29 ` Christophe Ricard
2017-03-21 18:36 ` Andy Shevchenko
2017-04-04 16:16 ` Andy Shevchenko
2017-04-05 8:09 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307102546.32224-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=aloisio.almeida@openbossa.org \
--cc=christophe.ricard@gmail.com \
--cc=lauro.venancio@openbossa.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).