From: Johan Hovold <johan@kernel.org>
To: Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>
Subject: [PATCH 0/7] NFC: fix device allocation and nfcmrvl crashes
Date: Wed, 29 Mar 2017 18:21:05 +0200 [thread overview]
Message-ID: <20170329162112.18121-1-johan@kernel.org> (raw)
This started out with the observation that the nfcmrvl_uart driver
unconditionally dereferenced the tty class device despite the fact that
not every tty has an associated struct device (Unix98 ptys). Some
further changes were needed in the common nfcmrvl code to fully address
this, some of which also incidentally fixed a few related bugs (e.g.
resource leaks in error paths).
While fixing this I stumbled over a regression in NFC core that lead to
broken registration error paths and misnamed workqueues.
Note that this has only been tested by configuring the n_hci line
discipline for different ttys without any actual NFC hardware connected.
Johan
Johan Hovold (7):
NFC: fix broken device allocation
NFC: nfcmrvl_uart: add missing tty-device sanity check
NFC: nfcmrvl: do not use device-managed resources
NFC: nfcmrvl: use nfc-device for firmware download
NFC: nfcmrvl: fix firmware-management initialisation
NFC: nfcmrvl_uart: fix device-node leak during probe
NFC: nfcmrvl_usb: use interface as phy device
drivers/nfc/nfcmrvl/fw_dnld.c | 7 +++++--
drivers/nfc/nfcmrvl/main.c | 25 +++++++++++++------------
drivers/nfc/nfcmrvl/uart.c | 11 +++++++----
drivers/nfc/nfcmrvl/usb.c | 4 +---
net/nfc/core.c | 31 ++++++++++++++++++-------------
net/nfc/nci/core.c | 3 +--
6 files changed, 45 insertions(+), 36 deletions(-)
--
2.12.2
next reply other threads:[~2017-03-29 16:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 16:21 Johan Hovold [this message]
2017-03-29 16:21 ` [PATCH 1/7] NFC: fix broken device allocation Johan Hovold
2017-03-29 16:21 ` [PATCH 2/7] NFC: nfcmrvl_uart: add missing tty-device sanity check Johan Hovold
2017-03-29 16:21 ` [PATCH 3/7] NFC: nfcmrvl: do not use device-managed resources Johan Hovold
2017-03-29 20:44 ` Johan Hovold
2017-03-29 16:21 ` [PATCH 4/7] NFC: nfcmrvl: use nfc-device for firmware download Johan Hovold
2017-03-29 16:21 ` [PATCH 5/7] NFC: nfcmrvl: fix firmware-management initialisation Johan Hovold
2017-03-29 16:21 ` [PATCH 6/7] NFC: nfcmrvl_uart: fix device-node leak during probe Johan Hovold
2017-03-29 16:21 ` [PATCH 7/7] NFC: nfcmrvl_usb: use interface as phy device Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329162112.18121-1-johan@kernel.org \
--to=johan@kernel.org \
--cc=aloisio.almeida@openbossa.org \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).