* [PATCH v3] rtlwifi: Replace hardcode value with macro
@ 2017-06-30 8:19 Souptick Joarder
2017-07-27 9:47 ` [v3] " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2017-06-30 8:19 UTC (permalink / raw)
To: kvalo, Larry.Finger, chaoming_li; +Cc: linux-wireless
In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
and hw->max_rate_tries are replaced by macro.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++---
drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
index bdc3791..f45d093 100644
--- a/drivers/net/wireless/realtek/rtlwifi/base.c
+++ b/drivers/net/wireless/realtek/rtlwifi/base.c
@@ -422,9 +422,9 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
/* TODO: Correct this value for our hw */
- /* TODO: define these hard code value */
- hw->max_listen_interval = 10;
- hw->max_rate_tries = 4;
+ /* defined these hard code values */
+ hw->max_listen_interval = MAX_LISTEN_INTERVAL;
+ hw->max_rate_tries = MAX_RATE_TRIES;
/* hw->max_rates = 1; */
hw->sta_data_size = sizeof(struct rtl_sta_info);
diff --git a/drivers/net/wireless/realtek/rtlwifi/base.h b/drivers/net/wireless/realtek/rtlwifi/base.h
index 02ff0c5..d03e198 100644
--- a/drivers/net/wireless/realtek/rtlwifi/base.h
+++ b/drivers/net/wireless/realtek/rtlwifi/base.h
@@ -65,6 +65,8 @@ enum ap_peer {
#define FRAME_OFFSET_ADDRESS3 16
#define FRAME_OFFSET_SEQUENCE 22
#define FRAME_OFFSET_ADDRESS4 24
+#define MAX_LISTEN_INTERVAL 10
+#define MAX_RATE_TRIES 4
#define SET_80211_HDR_FRAME_CONTROL(_hdr, _val) \
WRITEEF2BYTE(_hdr, _val)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [v3] rtlwifi: Replace hardcode value with macro
2017-06-30 8:19 [PATCH v3] rtlwifi: Replace hardcode value with macro Souptick Joarder
@ 2017-07-27 9:47 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2017-07-27 9:47 UTC (permalink / raw)
To: Souptick Joarder; +Cc: Larry.Finger, chaoming_li, linux-wireless
Souptick Joarder <jrdr.linux@gmail.com> wrote:
> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
> and hw->max_rate_tries are replaced by macro.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
The comment ("defined these...") in the code does not make sense, it
should be removed.
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/9818675/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-27 9:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 8:19 [PATCH v3] rtlwifi: Replace hardcode value with macro Souptick Joarder
2017-07-27 9:47 ` [v3] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).