archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <>
Subject: [bug report] NFC: fix broken device allocation
Date: Fri, 7 Jul 2017 12:33:34 +0300	[thread overview]
Message-ID: <20170707093334.zhnn3jrtqosbqdib@mwanda> (raw)

Hello Johan Hovold,

The patch 20777bc57c34: "NFC: fix broken device allocation" from Mar
30, 2017, leads to the following static checker warning:

	drivers/nfc/pn533/pn533.c:2653 pn533_register_device()
	error: 'priv->nfc_dev' dereferencing possible ERR_PTR()

  2639          skb_queue_head_init(&priv->resp_q);
  2640          skb_queue_head_init(&priv->fragment_skb);
  2642          INIT_LIST_HEAD(&priv->cmd_queue);
  2644          priv->nfc_dev = nfc_allocate_device(&pn533_nfc_ops, protocols,
  2645                                             priv->ops->tx_header_len +
  2646                                             PN533_CMD_DATAEXCH_HEAD_LEN,
  2647                                             priv->ops->tx_tail_len);

We changed this to return error pointers as well as NULL.  When
functions return a NULL as well as error pointers, then NULL is supposed
to be a special case of success but here it's just a failure.  That's
messy and bug prone.

  2648          if (!priv->nfc_dev) {
  2649                  rc = -ENOMEM;
  2650                  goto destroy_wq;
  2651          }
  2653          nfc_set_parent_dev(priv->nfc_dev, parent);

  2654          nfc_set_drvdata(priv->nfc_dev, priv);
  2656          rc = nfc_register_device(priv->nfc_dev);
  2657          if (rc)
  2658                  goto free_nfc_dev;

dan carpenter

             reply	other threads:[~2017-07-07  9:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07  9:33 Dan Carpenter [this message]
2017-07-07 18:32 ` [bug report] NFC: fix broken device allocation Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170707093334.zhnn3jrtqosbqdib@mwanda \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).