linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: imitsyanko@quantenna.com, kvalo@codeaurora.org,
	avinashp@quantenna.com, smatyukevich@quantenna.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 10/11] net: qtnfmac: constify pci_device_id.
Date: Tue, 18 Jul 2017 14:01:52 +0300	[thread overview]
Message-ID: <20170718110150.cmjg2ke6rfvz53jm@bars> (raw)
In-Reply-To: <1500315263-3373-1-git-send-email-arvind.yadav.cs@gmail.com>

> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c
> index 7fc4f0d..02337d8 100644
> --- a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c
> +++ b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c
> @@ -1336,7 +1336,7 @@ static SIMPLE_DEV_PM_OPS(qtnf_pcie_pm_ops, qtnf_pcie_suspend,
>                          qtnf_pcie_resume);
>  #endif
> 
> -static struct pci_device_id qtnf_pcie_devid_table[] = {
> +static const struct pci_device_id qtnf_pcie_devid_table[] = {
>         {
>                 PCIE_VENDOR_ID_QUANTENNA, PCIE_DEVICE_ID_QTN_PEARL,
>                 PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> --
> 2.7.4

Thanks !

Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>

  reply	other threads:[~2017-07-18 11:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 18:14 [PATCH 10/11] net: qtnfmac: constify pci_device_id Arvind Yadav
2017-07-18 11:01 ` Sergey Matyukevich [this message]
2017-08-03 10:10 ` [10/11] " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718110150.cmjg2ke6rfvz53jm@bars \
    --to=sergey.matyukevich.os@quantenna.com \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=avinashp@quantenna.com \
    --cc=imitsyanko@quantenna.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=smatyukevich@quantenna.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).