Re: [PATCH v2 2/2] crypto/algapi - make crypto_xor() take separate dst and src arguments

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2793 bytes --]

Hi Ard,

[auto build test ERROR on cryptodev/master]
[also build test ERROR on v4.13-rc1 next-20170721]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ard-Biesheuvel/crypto-algapi-use-separate-dst-and-src-operands-for-__crypto_xor/20170719-090848
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   drivers/crypto/vmx/aes_ctr.c: In function 'p8_aes_ctr_final':
   drivers/crypto/vmx/aes_ctr.c:107:29: warning: passing argument 3 of 'crypto_xor' makes integer from pointer without a cast [-Wint-conversion]
     crypto_xor(dst, keystream, src, nbytes);
                                ^~~
   In file included from include/crypto/scatterwalk.h:19:0,
                    from drivers/crypto/vmx/aes_ctr.c:29:
   include/crypto/algapi.h:197:20: note: expected 'unsigned int' but argument is of type 'u8 * {aka unsigned char *}'
    static inline void crypto_xor(u8 *dst, const u8 *src, unsigned int size)
                       ^~~~~~~~~~
>> drivers/crypto/vmx/aes_ctr.c:107:2: error: too many arguments to function 'crypto_xor'
     crypto_xor(dst, keystream, src, nbytes);
     ^~~~~~~~~~
   In file included from include/crypto/scatterwalk.h:19:0,
                    from drivers/crypto/vmx/aes_ctr.c:29:
   include/crypto/algapi.h:197:20: note: declared here
    static inline void crypto_xor(u8 *dst, const u8 *src, unsigned int size)
                       ^~~~~~~~~~

vim +/crypto_xor +107 drivers/crypto/vmx/aes_ctr.c

    89	
    90	static void p8_aes_ctr_final(struct p8_aes_ctr_ctx *ctx,
    91				     struct blkcipher_walk *walk)
    92	{
    93		u8 *ctrblk = walk->iv;
    94		u8 keystream[AES_BLOCK_SIZE];
    95		u8 *src = walk->src.virt.addr;
    96		u8 *dst = walk->dst.virt.addr;
    97		unsigned int nbytes = walk->nbytes;
    98	
    99		preempt_disable();
   100		pagefault_disable();
   101		enable_kernel_vsx();
   102		aes_p8_encrypt(ctrblk, keystream, &ctx->enc_key);
   103		disable_kernel_vsx();
   104		pagefault_enable();
   105		preempt_enable();
   106	
 > 107		crypto_xor(dst, keystream, src, nbytes);
   108		crypto_inc(ctrblk, AES_BLOCK_SIZE);
   109	}
   110	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53913 bytes --]