From: Kalle Valo <kvalo@codeaurora.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Nishant Sarmukadam <nishants@marvell.com>,
Xinming Hu <huxm@marvell.com>,
Shawn Lin <shawn.lin@rock-chips.com>
Subject: Re: mwifiex: fix compile warning of unused variable
Date: Fri, 28 Jul 2017 14:50:02 +0000 (UTC) [thread overview]
Message-ID: <20170728145002.5F3C860128@smtp.codeaurora.org> (raw)
In-Reply-To: <1499327433-70786-1-git-send-email-shawn.lin@rock-chips.com>
Shawn Lin <shawn.lin@rock-chips.com> wrote:
> We got a compile warning shows below:
>
> drivers/net/wireless/marvell/mwifiex/sdio.c: In function
> 'mwifiex_sdio_remove':
> drivers/net/wireless/marvell/mwifiex/sdio.c:377:6: warning: variable
> 'ret' set but not used [-Wunused-but-set-variable]
>
> Per the code, it didn't check if mwifiex_sdio_read_fw_status
> finish successfully. We should at least check the return of
> mwifiex_sdio_read_fw_status, otherwise the following check of
> firmware_stat and adapter->mfg_mode is pointless as the device
> is probably dead.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
f46a5b0156b1 mwifiex: fix compile warning of unused variable
--
https://patchwork.kernel.org/patch/9827585/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-07-28 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 7:50 [PATCH] mwifiex: fix compile warning of unused variable Shawn Lin
2017-07-06 7:57 ` Kalle Valo
2017-07-06 8:18 ` Shawn Lin
2017-07-06 17:11 ` Brian Norris
2017-07-25 12:33 ` Kalle Valo
2017-07-28 14:50 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728145002.5F3C860128@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=huxm@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).