archive mirror
 help / color / mirror / Atom feed
From: Samuel Ortiz <>
To: Johan Hovold <>
Cc: "David S. Miller" <>,,,
	Dan Carpenter <>,
	stable <>
Subject: Re: [PATCH] NFC: fix device-allocation error return
Date: Mon, 6 Nov 2017 00:54:14 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Johan,

On Sun, Jul 09, 2017 at 01:08:58PM +0200, Johan Hovold wrote:
> A recent change fixing NFC device allocation itself introduced an
> error-handling bug by returning an error pointer in case device-id
> allocation failed. This is clearly broken as the callers still expected
> NULL to be returned on errors as detected by Dan's static checker.
> Fix this up by returning NULL in the event that we've run out of memory
> when allocating a new device id.
> Note that the offending commit is marked for stable (3.8) so this fix
> needs to be backported along with it.
> Fixes: 20777bc57c34 ("NFC: fix broken device allocation")
> Cc: stable <>	# 3.8
> Reported-by: Dan Carpenter <>
> Signed-off-by: Johan Hovold <>
> ---
>  net/nfc/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks for the fix.


      parent reply	other threads:[~2017-11-05 23:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-09 11:08 [PATCH] NFC: fix device-allocation error return Johan Hovold
2017-07-22 13:32 ` Johan Hovold
2017-08-28  8:39   ` Johan Hovold
2017-11-05 23:54 ` Samuel Ortiz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).