From: James Cameron <quozl@laptop.org>
To: Xinming Hu <huxm@marvell.com>
Cc: Linux Wireless <linux-wireless@vger.kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
Brian Norris <briannorris@chromium.org>,
Dmitry Torokhov <dtor@google.com>,
rajatja@google.com, Zhiyuan Yang <yangzy@marvell.com>,
Tim Song <songtao@marvell.com>, Cathy Luo <cluo@marvell.com>,
James Cao <jcao@marvell.com>, Ganapathi Bhat <gbhat@marvell.com>,
Ellie Reeves <ellierevves@gmail.com>
Subject: Re: [PATCH v2] mwifiex: do not support change AP interface to station mode
Date: Wed, 22 Nov 2017 06:31:17 +1100 [thread overview]
Message-ID: <20171121193117.GB5400@us.netrek.org> (raw)
In-Reply-To: <1511265815-13087-1-git-send-email-huxm@marvell.com>
On Tue, Nov 21, 2017 at 08:03:35PM +0800, Xinming Hu wrote:
> Firmware do not support change interface from micro-ap mode to
> station mode, forbidden this operation in driver accordingly.
"forbidden" should be "forbid", for correct tense.
"in driver" is redundant and can be removed.
"accordingly" is also redundant.
Perhaps "Firmware do not support change interface from micro-ap mode
to station mode, forbid this operation."
> Signed-off-by: Cathy Luo <cluo@marvell.com>
> Signed-off-by: Xinming Hu <huxm@marvell.com>
> ---
> v2: remove unnecessary sta/uap combo check(James Cameron)
>
> drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index 6e0d9a9..4d45df8 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -1180,7 +1180,6 @@ static int mwifiex_deinit_priv_params(struct mwifiex_private *priv)
> case NL80211_IFTYPE_AP:
> switch (type) {
> case NL80211_IFTYPE_ADHOC:
Change interface type from micro-ap to adhoc is supported?
> - case NL80211_IFTYPE_STATION:
> return mwifiex_change_vif_to_sta_adhoc(dev, curr_iftype,
> type, params);
> break;
> --
> 1.9.1
>
--
James Cameron
http://quozl.netrek.org/
next prev parent reply other threads:[~2017-11-21 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 12:03 [PATCH v2] mwifiex: do not support change AP interface to station mode Xinming Hu
2017-11-21 19:31 ` James Cameron [this message]
2017-11-22 6:53 ` Xinming Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121193117.GB5400@us.netrek.org \
--to=quozl@laptop.org \
--cc=briannorris@chromium.org \
--cc=cluo@marvell.com \
--cc=dtor@google.com \
--cc=ellierevves@gmail.com \
--cc=gbhat@marvell.com \
--cc=huxm@marvell.com \
--cc=jcao@marvell.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rajatja@google.com \
--cc=songtao@marvell.com \
--cc=yangzy@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).