From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
Andrey Shevchenko <ashevchenko@quantenna.com>
Subject: Re: [PATCH 5/5] qtnfmac: add support for Topaz chipsets
Date: Mon, 8 Oct 2018 13:36:07 +0000 [thread overview]
Message-ID: <20181008133558.3jjmbwjl7n2rigpw@bars> (raw)
In-Reply-To: <87in2cr7pj.fsf@purkki.adurom.net>
> > This patch adds support for QSR1000/QSR2000 family of chipsets
> > to qtnfmac_pcie platform driver.
> >
> > QSR1000/QSR2000 (aka Topaz) is a family of 80MHz, 11ac Wave2,
> > 4x4/2x4/2x2 chips, including single and dual band devices.
> > Depending on specific chip model and firmware in use, either
> > STA or both STA and AP modes are supported.
> >
> > Patch adds Topaz support to qtnfmac_pcie driver. It is possible
> > to enable both Topaz and Pearl support in kernel configuration.
> > In that case proper platform bus will be selected on probing
> > based on chip ID.
> >
> > Signed-off-by: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
> > Signed-off-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
> > Signed-off-by: Andrey Shevchenko <ashevchenko@quantenna.com>
>
> [...]
>
> > --- a/drivers/net/wireless/quantenna/qtnfmac/qtn_hw_ids.h
> > +++ b/drivers/net/wireless/quantenna/qtnfmac/qtn_hw_ids.h
> > @@ -24,6 +24,7 @@
> > /* PCIE Device IDs */
> >
> > #define PCIE_DEVICE_ID_QTN_PEARL (0x0008)
> > +#define PCIE_DEVICE_ID_QTN_TOPAZ (0x0008)
>
> Same ids for both, is this really correct?
Yes, that is correct. This is one of the reasons why we switched
to chip ID for card identification. In fact, it can be configured
in firmware, but default PCI ID values are the same for both chipsets.
Regards,
Sergey
next prev parent reply other threads:[~2018-10-08 13:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 9:55 [PATCH 0/5] qtnfmac: add support for QSR1000/QSR2000 (aka Topaz) chipsets Sergey Matyukevich
2018-10-08 9:56 ` [PATCH 1/5] qtnfmac: use 'help' in Kconfig Sergey Matyukevich
2018-10-13 17:05 ` Kalle Valo
2018-10-08 9:56 ` [PATCH 2/5] qtnfmac: use SPDX identifier for pcie bus layer files Sergey Matyukevich
2018-10-08 9:56 ` [PATCH 3/5] qtnfmac_pcie: cleanup Pearl platform headers Sergey Matyukevich
2018-10-08 9:56 ` [PATCH 4/5] qtnfmac_pcie: use single PCIe driver for all platforms Sergey Matyukevich
2018-10-08 9:56 ` [PATCH 5/5] qtnfmac: add support for Topaz chipsets Sergey Matyukevich
2018-10-08 11:36 ` Kalle Valo
2018-10-08 13:36 ` Sergey Matyukevich [this message]
2018-10-13 12:14 ` Kalle Valo
2018-10-15 19:46 ` Sergey Matyukevich
2018-10-29 14:56 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008133558.3jjmbwjl7n2rigpw@bars \
--to=sergey.matyukevich.os@quantenna.com \
--cc=ashevchenko@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).