linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org,
	Cheng-Hao.Luo@mediatek.com, Ryder.Lee@mediatek.com
Subject: Re: [PATCH 2/3] mt76x0: phy: introduce tssi calibration support
Date: Fri, 2 Nov 2018 14:29:46 +0100	[thread overview]
Message-ID: <20181102132945.GB27823@localhost.localdomain> (raw)
In-Reply-To: <20181102130917.GB5247@redhat.com>

> (cc Mediatek.com engineers)
> 
> On Mon, Oct 29, 2018 at 10:31:24PM +0100, Lorenzo Bianconi wrote:
> > Run mt76x0 tssi calibration process if enabled in eeprom data.
> > Perform calibration procedure every 4s
> 
> I just checked the Mediatek vendor drivers for both MT7610E (at
> github https://github.com/i80s/mtk-sources ) and GPL relesed MT7610U driver
> are compiled without MT76x0_TSSI_CAL_COMPENSATION define.
> So seems TSSI compensation is not used or tested in vendor driver.

During the tests I carried out, TSSI calibration is disabled on my mt7610e
device (it runs temperature calibration) but it is enabled on my mt7610u
dongle and it seems to work properly.
Anyway more light on this topic from mtk folks is definitely very useful.

Regards,
Lorenzo

> 
> Perhaps Cheng-Hao Luo and Ryder Lee at Mediatek could clarify if this
> code is needed and is correct.
> 
> Thanks
> Stanislaw
> 
> 

  reply	other threads:[~2018-11-02 13:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 21:31 [PATCH 0/3] mt76x0: add tssi calibration support Lorenzo Bianconi
2018-10-29 21:31 ` [PATCH 1/3] mt76: move mt76x02_eeprom_copy in mt76x02-lib module Lorenzo Bianconi
2018-10-29 21:31 ` [PATCH 2/3] mt76x0: phy: introduce tssi calibration support Lorenzo Bianconi
2018-11-02 13:09   ` Stanislaw Gruszka
2018-11-02 13:29     ` Lorenzo Bianconi [this message]
2018-10-29 21:31 ` [PATCH 3/3] mt76x0: phy: use tssi reported value to configure tx power if available Lorenzo Bianconi
2018-11-05 17:00 ` [PATCH 0/3] mt76x0: add tssi calibration support Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181102132945.GB27823@localhost.localdomain \
    --to=lorenzo.bianconi@redhat.com \
    --cc=Cheng-Hao.Luo@mediatek.com \
    --cc=Ryder.Lee@mediatek.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).