From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99C38C43387 for ; Wed, 26 Dec 2018 01:23:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 628E120C01 for ; Wed, 26 Dec 2018 01:23:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="OzpGiYDx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725901AbeLZBW5 (ORCPT ); Tue, 25 Dec 2018 20:22:57 -0500 Received: from mta-p5.oit.umn.edu ([134.84.196.205]:42676 "EHLO mta-p5.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725863AbeLZBW4 (ORCPT ); Tue, 25 Dec 2018 20:22:56 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p5.oit.umn.edu (Postfix) with ESMTP id 58F95B92 for ; Wed, 26 Dec 2018 01:22:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p5.oit.umn.edu ([127.0.0.1]) by localhost (mta-p5.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ILEeV0UYo_He for ; Tue, 25 Dec 2018 19:22:55 -0600 (CST) Received: from mail-it1-f197.google.com (mail-it1-f197.google.com [209.85.166.197]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p5.oit.umn.edu (Postfix) with ESMTPS id 27E1BB60 for ; Tue, 25 Dec 2018 19:22:55 -0600 (CST) Received: by mail-it1-f197.google.com with SMTP id c128so18482652itc.0 for ; Tue, 25 Dec 2018 17:22:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=AAHoTsSyNIe43BLaEwGnXajRWoTfyjipo1H+0l91hMk=; b=OzpGiYDxGTYe05By8QY4VsUBw8YTW87quAQ84CteyHxUP+2gQgPnUsDrwmjHxZ7sK/ pKgF4Dtc32YeEUb5kkRdWKBMBrdKsXdiY0CsmopcH0KBI4T8DQjUmKaL6GumR6lc8f2j /l0ABrCcvg65UaB6hkn4OfvmkXtrHFy4lKB89/AgLzz6cxVTj+OChUre68H0oC9CBluP NOHTkYD100YQZZXjZF+XQax3OvTw/jDZLxBd0swXAzzW8bacjKzo5rCV6LlTBqphuPYt z012JGwXGJTMjyOZMrPPeKf/uX6vWarTHCSUV4IwJvUKujlBqXByQ/r6sWR0F73w3K3v hxNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AAHoTsSyNIe43BLaEwGnXajRWoTfyjipo1H+0l91hMk=; b=AYWk6uOsOSatKNKRvl2xrZw6fLf0alXmhw+aAWcW+XwssxOUVw8j1N1ktIKSuIjy/0 10VKCo9880hVKfLPiQsNKE1oyvr9KDmSisRV7jkMcnLZmnwGbgqE6rFN7zVfyxHLw/qy ywPJtU9cNLHp/JZbGRxlhlO8G8Vu0Q6LYo0wkoCMkfJdpjPBbYsi3H/yImMy+ZBa08p1 sNgZ8EcKQUU9P/pQhGTOu1YLeWHICuLAl1Ts8LF84NjCuxQBYb/RuoM5+cEScJvxavz7 h57y4+UCsod3+PxwDiJew4caiaJ6v0jxhAh8EgqTBXmigMTpt6e9Uxr4fQTl6uml5fy/ t4tg== X-Gm-Message-State: AA+aEWa/xDZRAKOjEZamyQlmPeStscDt1/iAvnRKveJsYPBvaAQkLc5r 6nWQwK0j1RQmX9B/+kAJ/tlhEjQpeHa4fqpCWtNRIkfxG0AAMdQN9Q+ZlUTA4fOUTsStVdF3Fn5 bR3y11hug8MDHOGxAd9hLxDgybZ0l4FM= X-Received: by 2002:a02:284:: with SMTP id 126mr12114845jau.47.1545787374831; Tue, 25 Dec 2018 17:22:54 -0800 (PST) X-Google-Smtp-Source: AFSGD/UEsaqFoxYQKLg11KutOSESE4hYftJeOcyDjv53pju66WJPbHcLwG89Z8BM0dA1e5lj300UkQ== X-Received: by 2002:a02:284:: with SMTP id 126mr12114833jau.47.1545787374602; Tue, 25 Dec 2018 17:22:54 -0800 (PST) Received: from localhost.localdomain (host-173-230-104-22.mnmigsc.mn.minneapolis.us.clients.pavlovmedia.net. [173.230.104.22]) by smtp.gmail.com with ESMTPSA id t7sm14817847iom.27.2018.12.25.17.22.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 25 Dec 2018 17:22:53 -0800 (PST) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , "David S. Miller" , Pieter-Paul Giesberts , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: brcm80211: add a check for the status of usb_register Date: Tue, 25 Dec 2018 19:22:24 -0600 Message-Id: <20181226012227.70524-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.2 (Apple Git-113) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org usb_register() may fail, so let's check its status and issue an error message if it fails. Signed-off-by: Kangjie Lu --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c index a4308c6e72d7..76cfaf6999c8 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c @@ -1550,6 +1550,10 @@ void brcmf_usb_exit(void) void brcmf_usb_register(void) { + int ret; + brcmf_dbg(USB, "Enter\n"); - usb_register(&brcmf_usbdrvr); + ret = usb_register(&brcmf_usbdrvr); + if (ret) + brcmf_err("usb_register failed %d\n", ret); } -- 2.17.2 (Apple Git-113)