From: "Július Milan" <jmilan.dev@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
gregkh@linuxfoundation.org, Adham.Abozaeid@microchip.com,
Ajay.Kathat@microchip.com
Subject: [PATCH v4] staging: wilc1000: fix registration frame size
Date: Mon, 7 Jan 2019 15:43:05 +0100 [thread overview]
Message-ID: <20190107144305.GA14627@localhost.localdomain> (raw)
Fixes the following sparse warnings:
drivers/staging/wilc1000/host_interface.c:2360:30: warning:
incorrect type in assignment (different base types)
expected restricted __le32 [addressable] [assigned] [usertype] frame_type
got restricted __le16 [usertype] <noident>
Fixes: 147ccfd451024 ("staging: wilc1000: handle mgmt_frame_register ops from cfg82011 context")
Signed-off-by: Július Milan <jmilan.dev@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
v3:
- nothing really changed since v1, v2, I just messed emails and then patch
format, sorry for that, it's my first patch :)
v4:
- changed struct wilc_reg_frame member frame_type type to le16
- reverted cast of frame_type to le32 in wilc_frame_register
- changed subject line, previous version has subject:
"[PATCH v3] staging: wilc1000: fix cast to restricted __le32"
https://www.spinics.net/lists/linux-wireless/msg181166.html
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 70c854d939ce..7acb790d850b 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -36,7 +36,7 @@ struct wilc_op_mode {
struct wilc_reg_frame {
bool reg;
u8 reg_id;
- __le32 frame_type;
+ __le16 frame_type;
} __packed;
struct wilc_drv_handler {
--
2.14.5
next reply other threads:[~2019-01-07 14:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 14:43 Július Milan [this message]
2019-01-08 2:52 ` [PATCH v4] staging: wilc1000: fix registration frame size Ajay.Kathat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107144305.GA14627@localhost.localdomain \
--to=jmilan.dev@gmail.com \
--cc=Adham.Abozaeid@microchip.com \
--cc=Ajay.Kathat@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).