Linux-Wireless Archive on lore.kernel.org
 help / Atom feed
* [PATCH 1/1] wlcore: Fix memory leak in case wl12xx_fetch_firmware failure
@ 2018-12-19  7:50 Zumeng Chen
  2019-01-10 11:32 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Zumeng Chen @ 2018-12-19  7:50 UTC (permalink / raw)
  To: linux-wireless, linux-arm-kernel, linux-kernel; +Cc: kvalo, tony, Zumeng Chen

Release fw_status, raw_fw_status, and tx_res_if when wl12xx_fetch_firmware
failed instead of meaningless goto out to avoid the following memory leak
reports(Only the last one listed):

unreferenced object 0xc28a9a00 (size 512):
  comm "kworker/0:4", pid 31298, jiffies 2783204 (age 203.290s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
  backtrace:
    [<6624adab>] kmemleak_alloc+0x40/0x74
    [<500ddb31>] kmem_cache_alloc_trace+0x1ac/0x270
    [<db4d731d>] wl12xx_chip_wakeup+0xc4/0x1fc [wlcore]
    [<76c5db53>] wl1271_op_add_interface+0x4a4/0x8f4 [wlcore]
    [<cbf30777>] drv_add_interface+0xa4/0x1a0 [mac80211]
    [<65bac325>] ieee80211_reconfig+0x9c0/0x1644 [mac80211]
    [<2817c80e>] ieee80211_restart_work+0x90/0xc8 [mac80211]
    [<7e1d425a>] process_one_work+0x284/0x42c
    [<55f9432e>] worker_thread+0x2fc/0x48c
    [<abb582c6>] kthread+0x148/0x160
    [<63144b13>] ret_from_fork+0x14/0x2c
    [< (null)>] (null)
    [<1f6e7715>] 0xffffffff

Signed-off-by: Zumeng Chen <zumeng.chen@gmail.com>
---
 drivers/net/wireless/ti/wlcore/main.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 26b1873..2e12de8 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -1085,8 +1085,11 @@ static int wl12xx_chip_wakeup(struct wl1271 *wl, bool plt)
 		goto out;
 
 	ret = wl12xx_fetch_firmware(wl, plt);
-	if (ret < 0)
-		goto out;
+	if (ret < 0) {
+		kfree(wl->fw_status);
+		kfree(wl->raw_fw_status);
+		kfree(wl->tx_res_if);
+	}
 
 out:
 	return ret;
-- 
2.7.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] wlcore: Fix memory leak in case wl12xx_fetch_firmware failure
  2018-12-19  7:50 [PATCH 1/1] wlcore: Fix memory leak in case wl12xx_fetch_firmware failure Zumeng Chen
@ 2019-01-10 11:32 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-01-10 11:32 UTC (permalink / raw)
  To: Zumeng Chen
  Cc: linux-wireless, linux-arm-kernel, linux-kernel, tony, Zumeng Chen

Zumeng Chen <zumeng.chen@gmail.com> wrote:

> Release fw_status, raw_fw_status, and tx_res_if when wl12xx_fetch_firmware
> failed instead of meaningless goto out to avoid the following memory leak
> reports(Only the last one listed):
> 
> unreferenced object 0xc28a9a00 (size 512):
>   comm "kworker/0:4", pid 31298, jiffies 2783204 (age 203.290s)
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>   backtrace:
>     [<6624adab>] kmemleak_alloc+0x40/0x74
>     [<500ddb31>] kmem_cache_alloc_trace+0x1ac/0x270
>     [<db4d731d>] wl12xx_chip_wakeup+0xc4/0x1fc [wlcore]
>     [<76c5db53>] wl1271_op_add_interface+0x4a4/0x8f4 [wlcore]
>     [<cbf30777>] drv_add_interface+0xa4/0x1a0 [mac80211]
>     [<65bac325>] ieee80211_reconfig+0x9c0/0x1644 [mac80211]
>     [<2817c80e>] ieee80211_restart_work+0x90/0xc8 [mac80211]
>     [<7e1d425a>] process_one_work+0x284/0x42c
>     [<55f9432e>] worker_thread+0x2fc/0x48c
>     [<abb582c6>] kthread+0x148/0x160
>     [<63144b13>] ret_from_fork+0x14/0x2c
>     [< (null)>] (null)
>     [<1f6e7715>] 0xffffffff
> 
> Signed-off-by: Zumeng Chen <zumeng.chen@gmail.com>

Patch applied to wireless-drivers-next.git, thanks.

ba2ffc96321c wlcore: Fix memory leak in case wl12xx_fetch_firmware failure

-- 
https://patchwork.kernel.org/patch/10736825/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-19  7:50 [PATCH 1/1] wlcore: Fix memory leak in case wl12xx_fetch_firmware failure Zumeng Chen
2019-01-10 11:32 ` Kalle Valo

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org linux-wireless@archiver.kernel.org
	public-inbox-index linux-wireless


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/ public-inbox