From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37A52C43387 for ; Thu, 10 Jan 2019 11:32:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0544E206B6 for ; Thu, 10 Jan 2019 11:32:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cWR1GpfA"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="gFgwfpnV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728451AbfAJLcL (ORCPT ); Thu, 10 Jan 2019 06:32:11 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:45802 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727938AbfAJLcL (ORCPT ); Thu, 10 Jan 2019 06:32:11 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 6695A60386; Thu, 10 Jan 2019 11:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1547119930; bh=H71mAAF+/Swkti+M7Ut2UeO+/FLR+Pmb716MuGIJzeY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=cWR1GpfAcRwUVBECSzVJIrpcjZt3c8utviOER4JPPqQeB9MlP+3GvGtkt1rjPkZn9 98YwFsdau+3NyauHtplTf42eLmwbsHqqhqG21GVNr21joCIx/I9GmvbYiy40L+pR25 JiVTxenBfEnUzpzA7Kd8PvEbmRKvMdbpfWS2LEOA= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 87CD060247; Thu, 10 Jan 2019 11:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1547119929; bh=H71mAAF+/Swkti+M7Ut2UeO+/FLR+Pmb716MuGIJzeY=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=gFgwfpnVMLj+KJm+Cf29MjJsGYv58wrxOumxoXgG4Mb2sI/i+3RYdlwnSqgraG61/ kGPYlnMtbD4dHGrV7IAGwXw/tZ/XAfj3IT6BdHEt1AfQQ56BRkT/6R13uPdeMZg/BE 188U5uIflEkXI2DBLRmO7d1dDwabE6iycZ6UGfP8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 87CD060247 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 1/1] wlcore: Fix memory leak in case wl12xx_fetch_firmware failure From: Kalle Valo In-Reply-To: <1545205829-31979-1-git-send-email-zumeng.chen@gmail.com> References: <1545205829-31979-1-git-send-email-zumeng.chen@gmail.com> To: Zumeng Chen Cc: , , , , Zumeng Chen User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190110113210.6695A60386@smtp.codeaurora.org> Date: Thu, 10 Jan 2019 11:32:10 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Zumeng Chen wrote: > Release fw_status, raw_fw_status, and tx_res_if when wl12xx_fetch_firmware > failed instead of meaningless goto out to avoid the following memory leak > reports(Only the last one listed): > > unreferenced object 0xc28a9a00 (size 512): > comm "kworker/0:4", pid 31298, jiffies 2783204 (age 203.290s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [<6624adab>] kmemleak_alloc+0x40/0x74 > [<500ddb31>] kmem_cache_alloc_trace+0x1ac/0x270 > [] wl12xx_chip_wakeup+0xc4/0x1fc [wlcore] > [<76c5db53>] wl1271_op_add_interface+0x4a4/0x8f4 [wlcore] > [] drv_add_interface+0xa4/0x1a0 [mac80211] > [<65bac325>] ieee80211_reconfig+0x9c0/0x1644 [mac80211] > [<2817c80e>] ieee80211_restart_work+0x90/0xc8 [mac80211] > [<7e1d425a>] process_one_work+0x284/0x42c > [<55f9432e>] worker_thread+0x2fc/0x48c > [] kthread+0x148/0x160 > [<63144b13>] ret_from_fork+0x14/0x2c > [< (null)>] (null) > [<1f6e7715>] 0xffffffff > > Signed-off-by: Zumeng Chen Patch applied to wireless-drivers-next.git, thanks. ba2ffc96321c wlcore: Fix memory leak in case wl12xx_fetch_firmware failure -- https://patchwork.kernel.org/patch/10736825/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches