From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 6/7] mt76: beaconing fixes for USB
Date: Mon, 28 Jan 2019 09:30:43 +0100 [thread overview]
Message-ID: <20190128083041.GA4132@redhat.com> (raw)
In-Reply-To: <20190124225048.GD2873@localhost.localdomain>
On Thu, Jan 24, 2019 at 11:50:49PM +0100, Lorenzo Bianconi wrote:
> > if (changed & BSS_CHANGED_BEACON_ENABLED) {
> > - tasklet_disable(&dev->pre_tbtt_tasklet);
> > + skb = NULL;
> > + if (info->enable_beacon && mt76_is_usb(dev))
> > + skb = ieee80211_beacon_get(hw, vif);
>
> What about moving this in mt76x02_mac_set_beacon_enable(), I guess the code
> will be more readable. Moreover you can move skb pointer declaration in
> if (changed & BSS_CHANGED_BEACON_ENABLED) block
Ok, make sense.
Regarding your other remarks, I do not see utility to address them.
Thanks
Stanislaw
next prev parent reply other threads:[~2019-01-28 8:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 15:44 [PATCH 0/7] mt76x02: Beacon support for USB Stanislaw Gruszka
2019-01-24 15:44 ` [PATCH 1/7] mt76x02: use mask for vifs Stanislaw Gruszka
2019-01-24 16:12 ` Lorenzo Bianconi
2019-01-24 16:20 ` Stanislaw Gruszka
2019-01-24 16:35 ` Lorenzo Bianconi
2019-01-24 22:20 ` Lorenzo Bianconi
2019-01-25 8:25 ` Stanislaw Gruszka
2019-01-25 9:02 ` Lorenzo Bianconi
2019-01-25 9:06 ` Stanislaw Gruszka
2019-01-25 9:47 ` Stanislaw Gruszka
2019-01-25 10:25 ` Lorenzo Bianconi
2019-01-25 12:41 ` Stanislaw Gruszka
2019-01-28 8:41 ` Felix Fietkau
2019-01-28 9:02 ` Stanislaw Gruszka
2019-01-28 11:16 ` Stanislaw Gruszka
2019-01-28 12:29 ` Felix Fietkau
2019-01-28 13:04 ` Stanislaw Gruszka
2019-01-24 15:44 ` [PATCH 2/7] mt76x02: use commmon add interface for mt76x2u Stanislaw Gruszka
2019-01-24 15:44 ` [PATCH 3/7] mt76x02: initialize mutli bss mode when set up address Stanislaw Gruszka
2019-01-24 15:44 ` [PATCH 4/7] mt76x02: minor beaconing init changes Stanislaw Gruszka
2019-01-24 22:32 ` Lorenzo Bianconi
2019-01-24 15:44 ` [PATCH 5/7] mt76x02: init beacon config for mt76x2u Stanislaw Gruszka
2019-01-24 22:33 ` Lorenzo Bianconi
2019-01-24 15:44 ` [PATCH 6/7] mt76: beaconing fixes for USB Stanislaw Gruszka
2019-01-24 22:50 ` Lorenzo Bianconi
2019-01-28 8:30 ` Stanislaw Gruszka [this message]
2019-01-24 15:44 ` [PATCH 7/7] mt76x02: enable support for IBSS, AP and MESH Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128083041.GA4132@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).